Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: point to "firebase.google" domain for hyperlinks in the usage section of README.md files (for the missing packages) #8818

Merged
merged 13 commits into from Jun 16, 2022

Conversation

nilsreichardt
Copy link
Contributor

@nilsreichardt nilsreichardt commented Jun 1, 2022

Description

#8814 was a draft pull request because it was just a proposal for a few packages 馃檲

This PR is a proposal and should show a proof of concept for the new format. If this is a good solution, I will continue adding the links for the other packages.

This PR adds the links for the other packages.

cc: @russellwheatley

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nilsreichardt. A few updates and it LGTM.

packages/firebase_analytics/firebase_analytics/README.md Outdated Show resolved Hide resolved
packages/cloud_functions/cloud_functions/README.md Outdated Show resolved Hide resolved
nilsreichardt and others added 2 commits June 7, 2022 11:54
Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
@Lyokone Lyokone merged commit 5bda8c9 into firebase:master Jun 16, 2022
@firebase firebase locked and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants