Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_messaging)!: upgrade messaging web to Firebase v9 JS SDK. #8860

Merged
merged 11 commits into from Jul 7, 2022

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jun 8, 2022

Description

Breaking Change

  1. isSupported() is a web API but is also on the method channel. It is now async so that API is now a Future which makes this a breaking change.

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added the platform: web Issues / PRs which are specifically for web. label Jun 8, 2022
@russellwheatley russellwheatley changed the title feat(firebase_core): upgrade core web to v9 SDK. feat(firebase_functions): upgrade firebase_functions web to v9 SDK. Jun 8, 2022
@russellwheatley russellwheatley changed the title feat(firebase_functions): upgrade firebase_functions web to v9 SDK. feat(firebase_functions): upgrade messaging web to v9 SDK. Jun 8, 2022
@russellwheatley russellwheatley changed the title feat(firebase_functions): upgrade messaging web to v9 SDK. feat(firebase_messaging): upgrade messaging web to v9 SDK. Jun 8, 2022
@russellwheatley russellwheatley changed the base branch from v9/core to master June 29, 2022 10:49
@russellwheatley russellwheatley changed the title feat(firebase_messaging): upgrade messaging web to v9 SDK. feat(firebase_messaging)!: upgrade messaging web to v9 SDK. Jun 29, 2022
# Conflicts:
#	packages/firebase_core/firebase_core_web/lib/src/firebase_core_web.dart
#	packages/firebase_core/firebase_core_web/lib/src/interop/app.dart
#	packages/firebase_core/firebase_core_web/lib/src/interop/core_interop.dart
#	packages/firebase_database/firebase_database_web/lib/src/interop/app.dart
@russellwheatley russellwheatley marked this pull request as ready for review July 6, 2022 16:27
@russellwheatley russellwheatley changed the title feat(firebase_messaging)!: upgrade messaging web to v9 SDK. feat(firebase_messaging)!: upgrade messaging web to Firebase v9 JS SDK. Jul 7, 2022
@russellwheatley russellwheatley merged commit f3a6bdc into master Jul 7, 2022
@russellwheatley russellwheatley deleted the v9/messaging branch July 7, 2022 07:39
@firebase firebase locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: web Issues / PRs which are specifically for web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants