Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_messaging): Added 'criticalAlert' to notification settings. #9004

Merged
merged 3 commits into from Jul 20, 2022
Merged

feat(firebase_messaging): Added 'criticalAlert' to notification settings. #9004

merged 3 commits into from Jul 20, 2022

Conversation

komaxx
Copy link
Contributor

@komaxx komaxx commented Jun 30, 2022

Enables apps to check whether the user permitted critical alerts (iOS only)

Description

The PR adds a critical to notification_settings.dart. This informs calling apps whether the user permitted the app to trigger critical alerts, which bypass the phone's "mute" and "focus" settings. Apple only.

The according flag criticalAlert was already part of the native ObjectiveC code but was not yet read in Dart. Just added that part.

Related Issues

  • none

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…her the user permitted critical alerts (iOS only)
@google-cla
Copy link

google-cla bot commented Jun 30, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@komaxx komaxx changed the title [firebase_messaging] Added 'critical' to notification settings. feat(firebase_messaging) Added 'critical' to notification settings. Jun 30, 2022
@komaxx komaxx changed the title feat(firebase_messaging) Added 'critical' to notification settings. feat(firebase_messaging): Added 'critical' to notification settings. Jun 30, 2022
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @komaxx, thanks for the PR! Could you rename to "criticalAlert" to match the iOS property?

…h the naming in iOS on which this is based
@komaxx
Copy link
Contributor Author

komaxx commented Jul 11, 2022

Hey @komaxx, thanks for the PR! Could you rename to "criticalAlert" to match the iOS property?

Absolutely! Done :)

@komaxx komaxx changed the title feat(firebase_messaging): Added 'critical' to notification settings. feat(firebase_messaging): Added 'criticalAlert' to notification settings. Jul 11, 2022
@komaxx
Copy link
Contributor Author

komaxx commented Jul 19, 2022

@russellwheatley If you don't mind, could you take another look?

@russellwheatley russellwheatley merged commit 4c425f2 into firebase:master Jul 20, 2022
@komaxx komaxx deleted the expose-critical-alert-permission-in-settings branch July 20, 2022 09:22
@firebase firebase locked and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants