Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [cloud_firestore_odm] Queries with multiple orderBy and a startAt throw an assertion error #9062

Closed
rrousselGit opened this issue Jul 8, 2022 · 0 comments 路 Fixed by #9185
Assignees
Labels
plugin: odm type: bug Something isn't working

Comments

@rrousselGit
Copy link
Contributor

rrousselGit commented Jul 8, 2022

Repro:

@Collection<Foo>('firestore-example-app/test/private-advanced')
@JsonSerializable()
class Foo {
  Foo({
    this.firstName,
    this.lastName,

  });

  final String? firstName;
  final String? lastName;
}

void main() {
  FooCollectionReference().orderByFirstName(startAt: 'John').orderByLastName();
}

This should be valid but fails.

Such issue raises another concern:

void main() {
  FooCollectionReference().orderByFirstName().orderByLastName(startAt: 'Smith');
}

It's probable that the startAt here is in fact applied on the firstName instead of lastName

@rrousselGit rrousselGit added type: bug Something isn't working Needs Attention This issue needs maintainer attention. plugin: odm and removed Needs Attention This issue needs maintainer attention. labels Jul 8, 2022
@Ehesp Ehesp linked a pull request Aug 3, 2022 that will close this issue
10 tasks
@Ehesp Ehesp added this to the [ODM] July 2022 milestone Aug 3, 2022
@firebase firebase locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plugin: odm type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants