Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [cloud_firestore] Pagination bug on web release mode only #9166

Closed
LiangHuangBC opened this issue Jul 20, 2022 · 5 comments
Closed

馃悰 [cloud_firestore] Pagination bug on web release mode only #9166

LiangHuangBC opened this issue Jul 20, 2022 · 5 comments
Labels
resolution: fixed A fix has been merged or is pending merge from a PR. type: bug Something isn't working

Comments

@LiangHuangBC
Copy link

Bug report

Describe the bug
query.startAfterDocument(lastDocSnapshot); is not working some time on release mode only. In my app, there are five pages in my firestore which can be fetched on dev mode correctly, but on release mode, there are only two pages.

Steps to reproduce

'''
firebase_core: ^1.19.2
firebase_auth: ^3.4.2
cloud_firestore: ^3.3.0
'''

Seems like latest V9.8.1 js sdk is buggy, similar issues :
#8235
#9089

I fixed #9089 by set persistence manually as #9117 mentioned. But after found this issue, the right thing is to roll back to previous version.

@LiangHuangBC LiangHuangBC added Needs Attention This issue needs maintainer attention. type: bug Something isn't working labels Jul 20, 2022
@LiangHuangBC
Copy link
Author

LiangHuangBC commented Jul 20, 2022

I passed around by roll back to previous version:

dependencies:
flutter:
sdk: flutter
firebase_core: 1.19.1
firebase_core_web: 1.6.6
firebase_auth: any
cloud_firestore: any
cloud_functions: any
firebase_storage: any
firebase_analytics: any
firebase_messaging: 11.4.4
firebase_crashlytics: any
firebase_performance: any
firebase_app_check: any

This roll back also fixed problems if you have:

  1. storage upload listener is not working on web.
  2. auth persistence is not working on web

@darshankawar darshankawar added the triage Issue is currently being triaged. label Jul 21, 2022
@darshankawar
Copy link

@LiangHuangBC
Can you provide a complete minimal reproducible code sample alongwith actual vs expected results ?
Also please provide your index.html where you are using latest V9.8.1 js sdk.

@darshankawar darshankawar added blocked: customer-response Waiting for customer response, e.g. more information was requested. and removed Needs Attention This issue needs maintainer attention. labels Jul 21, 2022
@LiangHuangBC
Copy link
Author

My JS SDK is injected by dart, there is nothing in my index.html.

@google-oss-bot google-oss-bot added Needs Attention This issue needs maintainer attention. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Jul 21, 2022
@darshankawar
Copy link

Can you provide a complete minimal reproducible code sample alongwith actual vs expected results ?

@darshankawar darshankawar added blocked: customer-response Waiting for customer response, e.g. more information was requested. and removed Needs Attention This issue needs maintainer attention. labels Jul 22, 2022
@russellwheatley
Copy link
Member

We have a release to fixing web persistence coming out today. Thanks.

@darshankawar darshankawar added resolution: fixed A fix has been merged or is pending merge from a PR. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. triage Issue is currently being triaged. labels Jul 28, 2022
@firebase firebase locked and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolution: fixed A fix has been merged or is pending merge from a PR. type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants