Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_core): broken homepage link in pubspec.yaml #9314

Merged
merged 1 commit into from Aug 11, 2022
Merged

fix(firebase_core): broken homepage link in pubspec.yaml #9314

merged 1 commit into from Aug 11, 2022

Conversation

OutdatedGuy
Copy link
Contributor

@OutdatedGuy OutdatedGuy commented Aug 8, 2022

Description

Adds / in homepage url in pubspec.yaml to get response status 200

Screenshots

Without /

image


With /

image

Related Issues

Fixes #9313

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Without the ending `/`, a `301` response is given
@google-cla
Copy link

google-cla bot commented Aug 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OutdatedGuy OutdatedGuy changed the title FIX: broken homepage link in pubspec.yaml fix(firebase_core): broken homepage link in pubspec.yaml Aug 8, 2022
@OutdatedGuy OutdatedGuy marked this pull request as draft August 8, 2022 06:37
@OutdatedGuy OutdatedGuy marked this pull request as ready for review August 8, 2022 06:38
@russellwheatley russellwheatley added type: documentation Improvements or additions to documentation plugin: core ready-to-merge labels Aug 8, 2022
@Ehesp
Copy link
Member

Ehesp commented Aug 11, 2022

The original link works fine for me?

@russellwheatley
Copy link
Member

@Ehespit it works, but it is a redirect and it affects the score on pub.dev as described in the description.

Screenshot 2022-08-11 at 10 22 37

@russellwheatley russellwheatley merged commit 7649c27 into firebase:master Aug 11, 2022
@firebase firebase locked and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plugin: core type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_core] Homepage link broken
5 participants