New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The example is producing an invalid markup due to duplicate IDs #94

Open

tihoni opened this issue Oct 12, 2019 · 1 comment

Assignees

Labels

bug

tihoni commented Oct 12, 2019

I know this is not the focus of the exercise, but I still believe we should strive to produce valid HTML.

Contributor

samtstern commented Oct 14, 2019

@tihoni thanks for reporting this! That's a good point, we should be using classes or unique IDs.

samtstern added the bug label

jhuleatt self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment