Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support of EC (Elliptic Curve) for JWKS #339

Open
istvan-szerletics opened this issue Jun 2, 2021 · 7 comments
Open

Add Support of EC (Elliptic Curve) for JWKS #339

istvan-szerletics opened this issue Jun 2, 2021 · 7 comments

Comments

@istvan-szerletics
Copy link

istvan-szerletics commented Jun 2, 2021

Hello together,

first of all I wanted to say thank you for developing this great library. I used the library very very much.

Our company has a problem at the moment, we have "ES256" tokens with EC method, and as I saw it in JWK.PHP "kty"="EC" is not supported, but only RSA. It would be super important to us because we have a very important customer, and for security reasons we need to validate the tokens that send us.

Could you please implement it? How big would be the effort? If you do it, then how long do you think it would take? If you don't implement it, then maybe you have a tip how I can validate these tokens?

Thanks a lot in advance!

With kind regards
Istvan

@istvan-szerletics
Copy link
Author

Hey, can you help me and answer my question?

@istvan-szerletics
Copy link
Author

HEYY BRO, WHATS UPP? can you at least answer???

@pwolanin
Copy link

Looks to be the same as #327 ?

@istvan-szerletics
Copy link
Author

Yes, I think it is same problem. Can you help us?

@pwolanin
Copy link

Sorry, don't have any availability to do consulting. I'm only using the JWT part anyhow, not JWK. Seems like the maintainers here are not too active, but yelling at them is not going to help.

You should at least fork and try adding the feature in a PR - I just made a start on Ed25519 keys for JWT: #343

@bshaffer
Copy link
Collaborator

bshaffer commented Feb 9, 2022

This is now available to try out as a dev branch. Please see #399 for more details and to help with testing.

@bshaffer
Copy link
Collaborator

bshaffer commented Aug 22, 2022

support for ed25519 was added in #343

We had a PR to add this support in JWKs as well here: #414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants