Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Cleanup test warnings #4485

Closed
jasonLaster opened this issue Oct 25, 2017 · 3 comments
Closed

Cleanup test warnings #4485

jasonLaster opened this issue Oct 25, 2017 · 3 comments

Comments

@jasonLaster
Copy link
Contributor

When we converted to React 15.6 we started seeing some createClass test warnings:

  Warning: Accessing PropTypes via the main React package is deprecated, and will be removed in  React v16.0. Use the latest available v15.* prop-types package from npm instead. For info on usage, compatibility, migration and more, see https://fb.me/prop-types-docs

It would be great to clean those up.

Screen Shot 2017-10-25 at 1.48.47 PM.png

@joel-bentley
Copy link
Contributor

joel-bentley commented Oct 27, 2017

It looks like these warnings are from a known issue in React v15.6 when using import * as React from 'react';
facebook/react#10583

The React team decided not to fix since these warnings go away when switch to React v16.0

@joel-bentley
Copy link
Contributor

So, the above is the case in only one instance src/components/shared/Modal.js

The rest of the errors are from React.createClass and React.PropTypes being used in the

devtools-launchpad
devtools-splitter
devtools-components

packages, which are part of https://github.com/devtools-html/devtools-core. I could make a PR over there.

@jasonLaster
Copy link
Contributor Author

@joel-bentley thanks that would be great

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants