{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":4279682,"defaultBranch":"master","name":"fish-shell","ownerLogin":"fish-shell","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2012-05-10T03:00:55.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1828073?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714944068.0","currentOid":""},"activityList":{"items":[{"before":"6ec09260dd79b108cae68506dcb0b5d2e960134f","after":"0246c938cadd50c373037b44c8c002531a9929a4","ref":"refs/heads/master","pushedAt":"2024-06-01T01:54:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Coalesce BlockType::function_call and BlockType::function_call_no_shadow\n\nThere's no need for two separate block types when one is merely a variant of the\nother. This may have been required under C++ but thanks to sum types (rust's\nenums) we don't need to do that any more.","shortMessageHtmlLink":"Coalesce BlockType::function_call and BlockType::function_call_no_shadow"}},{"before":"417e89a4b39f688f34777a97b3fc0bae83df74bb","after":"6ec09260dd79b108cae68506dcb0b5d2e960134f","ref":"refs/heads/master","pushedAt":"2024-05-31T21:22:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Changelog: document #5263 and provide workaround\n\n[ci skip]","shortMessageHtmlLink":"Changelog: document #5263 and provide workaround"}},{"before":"e1ee193822007a64dac1edd82c77eda8ff36eb13","after":"417e89a4b39f688f34777a97b3fc0bae83df74bb","ref":"refs/heads/master","pushedAt":"2024-05-31T02:32:22.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Work around WSLv1 not properly cleaning up stopped orphaned jobs\n\nSee #5263.","shortMessageHtmlLink":"Work around WSLv1 not properly cleaning up stopped orphaned jobs"}},{"before":"98642d307a1aa287418c52934de6200be2000812","after":"e1ee193822007a64dac1edd82c77eda8ff36eb13","ref":"refs/heads/master","pushedAt":"2024-05-30T22:05:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Speed up __fish_make_cache_dir\n\nDon't fork/exec an external process, especially one performing IO, if we don't\nhave to.\n\nThis, in turn, speeds up __fish_source_cached_completions which is rather slow\nunder WSL (and slower than it needs to be on other platforms).","shortMessageHtmlLink":"Speed up __fish_make_cache_dir"}},{"before":"7d77d7aa84a3d025b151c4fcc5cef9ef5d5750df","after":"98642d307a1aa287418c52934de6200be2000812","ref":"refs/heads/master","pushedAt":"2024-05-30T21:15:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Don't use a graphical browser under SSH\n\n...unless X is also being forwarded.\n\nSomeone else will have to figure out the Wayland equivalent (if that even\nexists). Not my monkey, not my circus.","shortMessageHtmlLink":"Don't use a graphical browser under SSH"}},{"before":"0a8fd05bb0b95dc7475037fb62cbf339c2980313","after":"7d77d7aa84a3d025b151c4fcc5cef9ef5d5750df","ref":"refs/heads/master","pushedAt":"2024-05-30T20:55:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Convert more block iteration methods to use iterators","shortMessageHtmlLink":"Convert more block iteration methods to use iterators"}},{"before":"f6200224fc1b655268910e68b2374831c786a34b","after":"0a8fd05bb0b95dc7475037fb62cbf339c2980313","ref":"refs/heads/master","pushedAt":"2024-05-30T20:52:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"docs/fish_add_path: Reword description\n\nUse \"directories\" explicitly instead of \"components\" to make it more\nclear that the arguments need to be directories, not files.\n\nAlso a bit on intent and variable scope.","shortMessageHtmlLink":"docs/fish_add_path: Reword description"}},{"before":"b495cffa50bb1442bf19172bf1c8d31bc1abcfe3","after":"f6200224fc1b655268910e68b2374831c786a34b","ref":"refs/heads/master","pushedAt":"2024-05-30T17:50:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Use Iterator::count() to check function stack depth","shortMessageHtmlLink":"Use Iterator::count() to check function stack depth"}},{"before":"a3e0d64e8840afdd4e6a6f22dacb05e1a9722b69","after":"b495cffa50bb1442bf19172bf1c8d31bc1abcfe3","ref":"refs/heads/master","pushedAt":"2024-05-30T17:25:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"fixup! Add workaround for targets with too small a main stack size","shortMessageHtmlLink":"fixup! Add workaround for targets with too small a main stack size"}},{"before":"46f6aa802489342b73782f61d7a669349b4874a3","after":"a3e0d64e8840afdd4e6a6f22dacb05e1a9722b69","ref":"refs/heads/master","pushedAt":"2024-05-30T17:21:02.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Remove usage of `env -u`\n\n`env -u` is not supported on all platforms we support (e.g. macOS/OS X 10.10).\nWe don't need these variables erased, blanked works just fine.","shortMessageHtmlLink":"Remove usage of env -u"}},{"before":"828b88a2128756c13912d558d3291ef779ca0d69","after":"46f6aa802489342b73782f61d7a669349b4874a3","ref":"refs/heads/master","pushedAt":"2024-05-29T19:08:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Update ssh-keygen completions\n\nDon't run `ssh` upon sourcing and don't rely on `ssh -Q` being available.","shortMessageHtmlLink":"Update ssh-keygen completions"}},{"before":"7bf3b57e47835ebdd5feb640db844973132cd0f1","after":"828b88a2128756c13912d558d3291ef779ca0d69","ref":"refs/heads/master","pushedAt":"2024-05-29T18:54:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Add issue reference to flatpak completion workaround\n\n[ci skip]","shortMessageHtmlLink":"Add issue reference to flatpak completion workaround"}},{"before":"390b40e02b13326bbf4f638516d4bfb181fd7894","after":"7bf3b57e47835ebdd5feb640db844973132cd0f1","ref":"refs/heads/master","pushedAt":"2024-05-29T18:26:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Fix buggy test_pthread() condvar test\n\nThere's no guarantee that a condition variable is stateful. The docs for\n`Condvar::notify_one()` actually say the opposite:\n\n> If there is a blocked thread on this condition variable, then it will be woken\n> up from its call to wait or wait_timeout. Calls to notify_one are not buffered\n> in any way.\n\nThis test was relying on the main loop obtaining the lock and entering the\ncondition variable sleep before the thread was scheduled and got around to\nnotifying the condition variable. If this non-deterministic behavior was not\nupheld, the test would time out since it would obtain the lock (either before or\nafter the variable were updated) then call `condvar.wait()` *after* the variable\nhad been updated and the condvar signalled, but without (atomically or even at\nall) checking to see if the desired wake precondition was fulfilled. As the\nchild thread had already run and the wake notification was NOT buffered, there\nwas nothing to wake the running thread.\n\nThere really wasn't any way to salvage the test as originally written, since the\nwrite to `ctx.val` was not in any way linked to the acquire/release of the mutex\nso regardless of whether or not the main thread obtained the mutex and checked\nthe value precondition before calling `condvar.wait()`, the child thread's write\ncould have happened after the check but before the wait() call. As such, the\ntest has been rewritten to use `wait_while()` but then also updated to bail in\ncase of a timeout instead of hanging indefinitely (since neither the `ctest`\nrunner nor the `cargo test` harness was timing out; `cargo test` would only\nreport that the test had exceeded 60 seconds but as long as it was not executed\nwith `cargo test -- -Z --ensure-time` (which is only available under nightly),\nthe test would not halt.\n\nIf this test were *intentionally* written to test the scenario that was timing\nout, it should be written deterministically in such a way that the main loop\ndid not run until after it was guaranteed that the variable had been updated\n(i.e. by looping until val became 5 or waiting for an AtomicBool indicating the\nupdate had completed to be set), but I'm not sure what the benefit in that would\nbe since the docs actually guarantee the opposite behavior (the notified state\nis explicitly not cached/buffered).\n\nIf we have fish code written with the assumption that condvar notifications\nprior to *any* call to `Condvar::wait()` *are* buffered, then that code should\nof course be revisited in light of this.","shortMessageHtmlLink":"Fix buggy test_pthread() condvar test"}},{"before":"8c364dc949ba943f5303843969eddf4ce547c7df","after":"390b40e02b13326bbf4f638516d4bfb181fd7894","ref":"refs/heads/master","pushedAt":"2024-05-29T11:00:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"krobelus","name":"Johannes Altmanninger","path":"/krobelus","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6853872?s=80&v=4"},"commit":{"message":"Fix regression not refreshing TTY timestamps after external command from binding\n\nCommit 8a7c3ce (Don't abandon line after writing control sequences, 2024-04-06)\nwas broken by 29f2da8 (Toggle terminal protocols lazily, 2024-05-16), fix that.\n\nFixes #10529","shortMessageHtmlLink":"Fix regression not refreshing TTY timestamps after external command f…"}},{"before":"5b7fd618674e6b9a5d533a57c6ffa8386b7a0a97","after":"8c364dc949ba943f5303843969eddf4ce547c7df","ref":"refs/heads/master","pushedAt":"2024-05-28T16:53:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"CHANGELOG: Fix awkwardly formatted issue reference\n\nThe :issue:`xxxx` template generates text in the format (#xxxx), so this was\nrendering as \"... See (#xxxx).\" which is just weird.\n\n[ci skip]","shortMessageHtmlLink":"CHANGELOG: Fix awkwardly formatted issue reference"}},{"before":"96416cc49e2cb9d1e87134bb28fdc58b0e66bd01","after":"5b7fd618674e6b9a5d533a57c6ffa8386b7a0a97","ref":"refs/heads/master","pushedAt":"2024-05-28T16:50:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Fix single-backtick-quoted code expressions in CHANGELOG.rst\n\nReminder that reStructuredText is awkward and you can't make sphinx treat these\nas inline code; they'll be formatted as italic text only.\n\nVim search expression:\n \\([`:]\\)\\@#10528)"}},{"before":"29b620b56c2ecdb7fa383ba02145933e847ae1a6","after":"f06143c11ae064d67ce6b17f1f5ad695f86ab98c","ref":"refs/heads/master","pushedAt":"2024-05-27T21:22:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"docs: Fix some formatting","shortMessageHtmlLink":"docs: Fix some formatting"}},{"before":"9e406e4fbc3ad825da34e32da62359f05be45af2","after":"29b620b56c2ecdb7fa383ba02145933e847ae1a6","ref":"refs/heads/master","pushedAt":"2024-05-27T18:49:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ridiculousfish","name":"Peter Ammon","path":"/ridiculousfish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/920838?s=80&v=4"},"commit":{"message":"Remove an unused type","shortMessageHtmlLink":"Remove an unused type"}},{"before":"6117b5071c4836a031300705f7fabfa6c46e9fff","after":"9e406e4fbc3ad825da34e32da62359f05be45af2","ref":"refs/heads/master","pushedAt":"2024-05-27T18:18:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ridiculousfish","name":"Peter Ammon","path":"/ridiculousfish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/920838?s=80&v=4"},"commit":{"message":"Silence some clippies","shortMessageHtmlLink":"Silence some clippies"}},{"before":"7850142bef794db4d031fb6e1ec9dd7906a9f459","after":"6117b5071c4836a031300705f7fabfa6c46e9fff","ref":"refs/heads/master","pushedAt":"2024-05-27T15:20:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Don't ignore assert_sorted_by_name doctest","shortMessageHtmlLink":"Don't ignore assert_sorted_by_name doctest"}},{"before":"8880fa8dd7f868f2c098b7b845caab2affc2e4f9","after":"7850142bef794db4d031fb6e1ec9dd7906a9f459","ref":"refs/heads/master","pushedAt":"2024-05-27T10:48:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"printf/tests: Use c_char instead of i8\n\nBreaks on arm again","shortMessageHtmlLink":"printf/tests: Use c_char instead of i8"}},{"before":"f84b1993ec706919340ad82b956c3e446616cce7","after":"8880fa8dd7f868f2c098b7b845caab2affc2e4f9","ref":"refs/heads/master","pushedAt":"2024-05-27T03:12:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"feat: add completions for k8s tools (kustomize, flux) (#10473)\n\n* feat: add completions for kustomize\r\n\r\n* feat: add completions for FluxCD\r\n\r\n* Update flux.fish\r\n\r\n* Update kustomize.fish\r\n\r\n---------\r\n\r\nCo-authored-by: Mahmoud Al-Qudsi ","shortMessageHtmlLink":"feat: add completions for k8s tools (kustomize, flux) (#10473)"}},{"before":"dbf6dfd5d24c003ee78b232aa69c07a55a5b2f78","after":"f84b1993ec706919340ad82b956c3e446616cce7","ref":"refs/heads/master","pushedAt":"2024-05-27T03:06:11.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Add `path basename -E` tests","shortMessageHtmlLink":"Add path basename -E tests"}},{"before":"4868166f86e2f6c7c54082c36c9c7a5d67dc1092","after":"dbf6dfd5d24c003ee78b232aa69c07a55a5b2f78","ref":"refs/heads/master","pushedAt":"2024-05-27T03:05:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"completions/flatpak: dynamically complete `flatpak install`","shortMessageHtmlLink":"completions/flatpak: dynamically complete flatpak install"}},{"before":"84d057e7b7f66051ccfcc615cea9485af8e2a9d0","after":"4868166f86e2f6c7c54082c36c9c7a5d67dc1092","ref":"refs/heads/master","pushedAt":"2024-05-27T02:44:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"completions/rustc: preserve trailing = in -Z values","shortMessageHtmlLink":"completions/rustc: preserve trailing = in -Z values"}},{"before":"114856e1d97e10f91ec3d9268101bd6c04849988","after":"84d057e7b7f66051ccfcc615cea9485af8e2a9d0","ref":"refs/heads/master","pushedAt":"2024-05-27T02:33:57.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Finish refactoring rustc completions\n\n* Properly handle a lot more -Z completion formats as suggested by `rustc -Z\n help`\n* Don't run any `rustc` commands when sourcing `rustc.fish`; these invocations\n are instead deferred until the user attempts to complete the specific switch.\n* Support CSV -A/F/D/W values","shortMessageHtmlLink":"Finish refactoring rustc completions"}},{"before":"94f13a50f5527c880451b4c9c33ce8d464cf4dad","after":"114856e1d97e10f91ec3d9268101bd6c04849988","ref":"refs/heads/master","pushedAt":"2024-05-27T01:57:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"git: add --reuse-message and --reedit-message completion (#10530)","shortMessageHtmlLink":"git: add --reuse-message and --reedit-message completion (#10530)"}},{"before":"b9b7dc5f6c17c18de1e97598232fd97be44971d7","after":"94f13a50f5527c880451b4c9c33ce8d464cf4dad","ref":"refs/heads/master","pushedAt":"2024-05-26T20:07:27.000Z","pushType":"pr_merge","commitsCount":4,"pusher":{"login":"ridiculousfish","name":"Peter Ammon","path":"/ridiculousfish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/920838?s=80&v=4"},"commit":{"message":"Add musl libc to our license.rst\n\nThe new printf is derived from musl libc. Add it to license.rst to reflect our\nusage.","shortMessageHtmlLink":"Add musl libc to our license.rst"}},{"before":"52d1806e1f42bcd31a02d38a5d1880c69b0b3b4d","after":"b9b7dc5f6c17c18de1e97598232fd97be44971d7","ref":"refs/heads/master","pushedAt":"2024-05-26T08:51:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"fmt","shortMessageHtmlLink":"fmt"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWYMxmAA","startCursor":null,"endCursor":null}},"title":"Activity · fish-shell/fish-shell"}