Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid env DISPLAY_ACCESS_LOG #2770

Open
saltbo opened this issue Apr 4, 2023 · 4 comments · May be fixed by #2771
Open

Invalid env DISPLAY_ACCESS_LOG #2770

saltbo opened this issue Apr 4, 2023 · 4 comments · May be fixed by #2771
Labels
bug

Comments

@saltbo
Copy link
Contributor

saltbo commented Apr 4, 2023 •
edited

Fission/Kubernetes version

$ fission version
$ kubectl version

Kubernetes platform (e.g. Google Kubernetes Engine)

Describe the bug

image

To Reproduce

Expected result

confirm a access log format like envoy or nginx:

[2016-04-15T20:17:00.310Z] "POST /api/v1/locations HTTP/2" 204 - 154 0 226 100 "10.0.35.28"
"nsq2http" "cc21d9b0-cf5c-432b-8c7e-98aeb7988cd2" "locations" "tcp://10.0.2.1:80"
[172.24.128.216] - - [04/Apr/2023:07:58:46 +0000] "GET /api/server/toggles HTTP/1.1" 200 1065 0.025 "-" saos-xxx-xxx-api.test.k8s.xxxxxx.com DIRECT/10.24.85.13:17199 application/json "Rust/1.1.0" "172.24.128.216" 247 [test-xx-xx-probe-api-17199] 1065 0.025 200 c1f07a233a3a83ce9c414ed0c896cdc4

or use json

{"level":"info","ts":"2023-04-04T16:42:44.686+0800","caller":"accesslog/logger.go:33","msg":"/","trace_id":"d26e082174591fa2da0db5576e194766","host":"127.0.0.1:55416","method":"GET","uri":"/","proto":"HTTP/1.1","status":200,"request_length":0,"body_bytes_sent":19,"upstream_addr":"-","upstream_response_length":-1,"upstream_response_time":-1,"upstream_status":-1}

Actual result

Screenshots/Dump file

$ fission support dump

Additional context
@saltbo saltbo linked a pull request Apr 4, 2023 that will close this issue
Open
5 tasks
@NikhilSharmaWe
Copy link
Member

NikhilSharmaWe commented Apr 6, 2023 •
edited

@sanketsudake Could you please take a look at this issue and let us know whether this is a reasonable feature add or not? So, @saltbo can continue to work on it.

@NikhilSharmaWe
Copy link
Member

@sanketsudake

@sanketsudake
Copy link
Member

Sorry to get delayed response, good to have. Also @shubham-bansal96 checking PR and trying it out.

@shubham-bansal96
Copy link
Contributor

@saltbo I am not able to see the logs as mentioned by you in this PR.
I have enabled DISPLAY_ACCESS_LOG env variable in using helm chart and i can see this env variable is being set inside container.
I created a new function and test it, but i can't see the logs for router as you mentioned.

Please let me know if i miss anything in order to get the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add an access logger for the router saltbo/fission
4 participants
@sanketsudake @saltbo @shubham-bansal96 @NikhilSharmaWe