New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrator stripped window.mixpanel inside mixpanel.js and replaced it just with mixpanel #54

Open

igorT opened this issue Mar 23, 2015 · 3 comments

Collaborator

igorT commented Mar 23, 2015

Not really sure how/why but this can lead to very hard to track down errors

Collaborator

tonysherbondy commented Mar 23, 2015

Hmmm, I thought we had removed the window stripping. And if we left it, I'm not so sure what it is useful for now?

Owner

fivetanley commented Mar 24, 2015

Looks like it is still there, I may have messed this up in a refactoring... https://github.com/fivetanley/ember-cli-migrator/blob/master/lib/migrator-visitor.js#L69

hefox commented Apr 27, 2018

I've had this with window.location as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment