Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support migrating "basic" classes eg. "App.Route" to "app/routes/basic" #63

Open
joeruello opened this issue Apr 17, 2015 · 1 comment · May be fixed by #67
Open

Support migrating "basic" classes eg. "App.Route" to "app/routes/basic" #63

joeruello opened this issue Apr 17, 2015 · 1 comment · May be fixed by #67

Comments

@joeruello
Copy link

We have a fairly large app (50+ routes) where we have added a App.Route to encapsulate common functionality. Currently, the migrator will migrate Route.js to -.js, and all other routes will try and import app\routes\-.

According to http://www.ember-cli.com/#using-modules it should be migrated to app/routes/basic

We also do the same with views/components/controllers, but I think (hope) that this is a general clause in the resolver rather than something route specific.

Happy to work on a PR, is there anyone I can bounce ideas and questions off?

@igorT
Copy link
Collaborator

igorT commented Apr 17, 2015

I feel like we would probably need to hard code/edge case this.
https://github.com/fivetanley/ember-cli-migrator/blob/master/lib/typed-export.js#L94 seems like the function you would want to modify

@joeruello joeruello linked a pull request May 11, 2015 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants