Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range tombstones/delete_range/delete_prefix #2

Open
marvin-j97 opened this issue Dec 16, 2023 · 0 comments
Open

Range tombstones/delete_range/delete_prefix #2

marvin-j97 opened this issue Dec 16, 2023 · 0 comments
Labels
enhancement New feature or request epic help wanted Extra attention is needed performance possibly breaking

Comments

@marvin-j97
Copy link
Contributor

marvin-j97 commented Dec 16, 2023

Use prefix .next and .next_back to get a range for delete_prefix

Considerations

  • Need to check tombstone deletion range when doing point reads and range reads
  • Need to fragment tombstones so in Levelled a segment only has the range tombstones of its range (important going from L0 to L1)
  • Need to correctly evict data on merge: this should happen implicitly as a BoxedIterator should just get the DeleteRangeTable, handle deleted items internally, and the MergeIterator should work implicitly
  • If a range delete covers an entire segment or the requested range/prefix, any range/prefix scan over it should short-circuit to immediately return None
  • Segments need to access tree-level DeleteRange memtable and sealed ones, too
@marvin-j97 marvin-j97 added enhancement New feature or request help wanted Extra attention is needed labels Dec 16, 2023
@marvin-j97 marvin-j97 transferred this issue from fjall-rs/fjall Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic help wanted Extra attention is needed performance possibly breaking
Projects
None yet
Development

No branches or pull requests

1 participant