Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Error or a Bug in documentation #1091

Open
arnavnagpurkar opened this issue Mar 24, 2024 · 1 comment
Open

Syntax Error or a Bug in documentation #1091

arnavnagpurkar opened this issue Mar 24, 2024 · 1 comment

Comments

@arnavnagpurkar
Copy link

Bug

What is the current behavior
In the website https://fkhadra.github.io/react-toastify/introduction/ The "Toast Container" has a bug.
image
in the <ToastContainer/> there is a attribute transition where : semicolon is added instead of = equal too sign.
When we assign value to attributes we need to insert = sign instead of : semicolons as in JSON.
And the value Bounce must also be enclosed in the quotes or double quotes.
If user will copy from this documentation then he'll face errors.

expected behaviour
User should not face error.
We need to updated it in the documentation to:

<ToastContainer
  position="top-right"
  autoClose={5000}
  hideProgressBar={false}
  newestOnTop={false}
  closeOnClick
  rtl={false}
  pauseOnFocusLoss
  draggable
  pauseOnHover
  theme="light"
  transition="Bounce",
/>

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
This issue is applicable to all versions of react and next.js

@cjboco
Copy link

cjboco commented May 15, 2024

I believe is should be:

import { ToastContainer, Bounce } from 'react-toastify';

<ToastContainer
position="top-right"
autoClose={5000}
hideProgressBar={false}
newestOnTop={false}
closeOnClick
rtl={false}
pauseOnFocusLoss
draggable
pauseOnHover
theme="light"
transition={Bounce}
/>
{/* Same as */}
<ToastContainer />

transition needs a ToastTransition | undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants