Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: PE File Support #258

Open
MrSynAckSter opened this issue Nov 30, 2021 · 3 comments
Open

Feature Request: PE File Support #258

MrSynAckSter opened this issue Nov 30, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MrSynAckSter
Copy link

The documentation claims that the system only supports ELF binaries.

It would be very useful to me if the system supported PE files.

@Enkelmann Enkelmann added enhancement New feature or request help wanted Extra attention is needed labels Dec 1, 2021
@Enkelmann
Copy link
Collaborator

I would also very much like better PE-support! :-)

For future reference some notes on the current state of PE support (at the time of this comment):

  • There already exists experimental support for PE files. However, it is not well tested (e.g. most acceptance tests for PE files are disabled).
  • There are known issues for PE files. See issue Proper handling of calling conventions for PE files #250. There is also a high likelihood of more issues with the analysis for PE files that I am not yet aware of.
  • Because of the above, one has to assume that the cwe_checker analyses are not reliable on PE files.

Unfortunately, ELF files have priority for us right now and we do not have enough people working on the project to tackle better PE support at the same time. At some point we are going to work on this, but I cannot yet say when this will be. In the meantime I would be happy to help and mentor any outside contributors willing to work on the subject!

@MrSynAckSter
Copy link
Author

That's awesome to know. I am currently trying to improve my static analysis skills. If you have any suggestions for contributing to the project, I'd be glad to help. I'll trying and bang my head against #250 and see if I can't understand how your system works.

@Enkelmann
Copy link
Collaborator

Feel free to ask many questions about the things you don't understand. :-) For #250 a possible starting point would be to look at the use cases of the Project::get_standard_calling_convention method and to figure out how these cases should be handled for PE files. Another starting point is to just take a simple example binary and trying to figure out what happens internally by using lots of debug printing.

@fkie-cad fkie-cad deleted a comment from XVilka Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants