Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused options in GlobalShortcuts::BindShortcuts impl #1311

Open
dcz-self opened this issue Mar 21, 2024 · 0 comments
Open

Unused options in GlobalShortcuts::BindShortcuts impl #1311

dcz-self opened this issue Mar 21, 2024 · 0 comments
Labels

Comments

@dcz-self
Copy link

Operating System

n/a

XDG Desktop Portal version

Git

XDG Desktop Portal version (Other)

No response

Desktop Environment

Other

Desktop Environment (Other)

No response

Expected Behavior

The spec doesn't have unexplained or unneeded parts.

Current Behavior

The non-impl side of BindShortcuts takes an option useful for generating the handle. The impl-side call receives a fully-formed handle, so there's no option necessary. Still, there's the "option" argument in the docs, which is completely lacking any description whatsoever.

The actual code for handling this in xdg-desktop-portal silently drops the options on the floor.

The ListShortcuts call doesn't have one, so it seems unnecessary and unnecessarily confusing.

Steps to Reproduce

  1. Go to org-freedesktop-impl-portal-globalshortcuts-bindshortcuts
  2. Notice "options"
  3. Notice lack of description.
    ...

Anything else we should know?

No response

@dcz-self dcz-self added the bug label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Triage
Development

No branches or pull requests

1 participant