Polyline filled with borderColor

[Ahmed-gubara]

Starting with version 0.11.0 with PR #766
Using Polyline to draw path creates shapes (with borderColor), unless you pass Colors.transparent as borderColor.

Going through the source code i found this part

flutter_map/lib/src/layer/polyline_layer.dart

Lines 153 to 161 in e8389e1

	Paint filterPaint;
	if (polylineOpt.borderColor != null) {
	filterPaint = Paint()
	..color = polylineOpt.borderColor.withAlpha(255)
	..strokeWidth = polylineOpt.strokeWidth
	..strokeCap = StrokeCap.round
	..strokeJoin = StrokeJoin.round
	..blendMode = BlendMode.dstOut;
	}

and

flutter_map/lib/src/layer/polyline_layer.dart

Lines 188 to 195 in e8389e1

	if (borderPaint != null) {
	if (filterPaint != null) {
	filterPaint.style = PaintingStyle.stroke;
	_paintLine(canvas, polylineOpt.offsets, borderPaint);
	}
	borderPaint?.style = PaintingStyle.stroke;
	_paintLine(canvas, polylineOpt.offsets, filterPaint);
	}

Swapping filterPaint with borderPaint in the function call _paintLine(...) makes Polyline works normally

Should i make PR for that, or is this intentional?

[kengu]

@escamoteur - I guess the intention was not to change default behaviour of polyline filling?

[escamoteur]

nope, that wasn't intended

[escamoteur]

yeah, PR would be nice

[kengu]

@Ahmed-gubara A PR is much appreciated. Add me as reviewer and I will look at it asap.

[escamoteur]

could you check if this is still the case in my null safety branch?

[Ahmed-gubara]

@escamoteur It's still present in your null safety branch.
I've made a PR with just placing the line borderPaint.style = PaintingStyle.stroke; before the paint statement.

[escamoteur]

could you make a PR on https://github.com/escamoteur/flutter_map/tree/nullsafety?

[Ahmed-gubara]

@escamoteur I've made the PR escamoteur#3, but getting All checks have failed with issues related to files I've not changed.