Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Module Name #80

Open
fredrik-yttergren opened this issue Nov 2, 2018 · 3 comments
Open

Automatic Module Name #80

fredrik-yttergren opened this issue Nov 2, 2018 · 3 comments

Comments

@fredrik-yttergren
Copy link

Hi. Thanks for an excellent library. I'm currently looking at migration from Java 8 to Java 11 in projects at work and am having issues relating to the module path, especially with the lack of automatic module name for this project. I understand the value of remaining compatible with Java 6, so would suggest that you add an Automatic-Module-Name entry to your manifest-file to make life easier for people using the module path as well as "reserving" a name for future reference.

I'm not well versed in Maven, but I think something like the below would work:

<plugin>
    <artifactId>maven-jar-plugin</artifactId>
    <version>2.4</version>
    <configuration>
        <archive>
            <manifestEntries>
                <Automatic-Module-Name>com.flipkart.zjsonpatch</Automatic-Module-Name>
            </manifestEntries>
        </archive>
    </configuration>
</plugin>

Cheers!

@vishwakarma
Copy link
Member

vishwakarma commented Nov 2, 2018

Thanks, @fredrik-yttergren for bringing out the issue.
Please allow me a couple of days to try and test it out ( since I haven't used Java 11 and need a bit of background before doing the requests change :) OR feel free to raise a PR )

@fredrik-yttergren
Copy link
Author

Sure, no worries, I'm just learning it myself right now by trial and error ;)

@vab2048
Copy link

vab2048 commented Dec 6, 2020

This issue seems to persist in 2020 - any update on how to deal with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants