Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: issue with semantic tokens / source locations #7637

Open
magnus-madsen opened this issue Apr 27, 2024 · 3 comments
Open

Parser: issue with semantic tokens / source locations #7637

magnus-madsen opened this issue Apr 27, 2024 · 3 comments
Assignees
@herluf-ba
Labels
bug Something isn't working high priority Requires immediate attention

Comments

@magnus-madsen
Copy link
Member

See here:

image

It seems that the parsing/weeding/desugaring of + makes it token span too long. I think this behavior is new.

Note how the literal of x is colored compared to y.
@magnus-madsen magnus-madsen added the bug Something isn't working label Apr 27, 2024
@herluf-ba
Copy link
Contributor

Yep, that seems like a Parser issue.

@magnus-madsen magnus-madsen added high priority Requires immediate attention and removed high priority Requires immediate attention labels May 1, 2024
@magnus-madsen
Copy link
Member Author

Downgraded priority.

@magnus-madsen magnus-madsen added the high priority Requires immediate attention label May 15, 2024
@magnus-madsen
Copy link
Member Author

@herluf-ba Reupgraded priority because wrong source locations are bad for other compiler errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@herluf-ba herluf-ba

Labels
bug Something isn't working high priority Requires immediate attention
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@magnus-madsen @herluf-ba