-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InvokeMethod2
to front-end ASTs
#7749
Comments
|
I think InvokeMethod2 is fine. It will replace InvokeMethod at some point. |
Your example code doesnt really match the structure of the asts, i guess we add it to parsedAst as a JvmOp and then later an atomic op also |
Why not? Compare it to WeededAst.Expr.InvokeMethod. |
Looking at JvmOp I would not add it there. The structure is very different. InvokeMethod is now much closer to Apply than it is to an import. |
Yes, we also concluded that after some tinkering |
Add a new node:
Just below the existing
InvokeMethod
.To begin with, we should just support the syntax:
Here
name2
is aName.Ident
. We should also parsename1
as aName.Ident
, but wrap it in anExpr.Var
.That way, we can later extend the parser without making changes to the rest.
The text was updated successfully, but these errors were encountered: