From cb9903507250eaaf815b174f46887c6f2d543b4d Mon Sep 17 00:00:00 2001 From: Federico Zivolo Date: Sun, 15 Apr 2018 14:07:58 +0200 Subject: [PATCH] refactored code --- packages/popper/src/utils/getBoundaries.js | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/packages/popper/src/utils/getBoundaries.js b/packages/popper/src/utils/getBoundaries.js index 10d015805e..24285c40f4 100644 --- a/packages/popper/src/utils/getBoundaries.js +++ b/packages/popper/src/utils/getBoundaries.js @@ -13,7 +13,7 @@ import getFixedPositionOffsetParent from './getFixedPositionOffsetParent'; * @memberof Popper.Utils * @param {HTMLElement} popper * @param {HTMLElement} reference - * @param {number} padding + * @param {number|Object} padding - A number or an object containing padding values for top, right, bottom, and left * @param {HTMLElement} boundariesElement - Element used to define the boundaries * @param {Boolean} fixedPosition - Is in fixed position mode * @returns {Object} Coordinates of the boundaries @@ -69,17 +69,11 @@ export default function getBoundaries( } // Add paddings - if(!isNaN(padding)){ - boundaries.left += padding; - boundaries.top += padding; - boundaries.right -= padding; - boundaries.bottom -= padding; - } else { - boundaries.left += padding.left || 0; - boundaries.top += padding.top || 0; - boundaries.right -= padding.right || 0; - boundaries.bottom -= padding.bottom || 0; - } + const isPaddingNumber = typeof padding === 'number'; + boundaries.left += isPaddingNumber ? padding : padding.left || 0; + boundaries.top += isPaddingNumber ? padding : padding.top || 0; + boundaries.right -= isPaddingNumber ? padding : padding.right || 0; + boundaries.bottom -= isPaddingNumber ? padding : padding.bottom || 0; return boundaries; }