Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute License File #1624

Closed
michaelbull opened this issue Apr 15, 2022 · 5 comments · Fixed by #1626
Closed

Distribute License File #1624

michaelbull opened this issue Apr 15, 2022 · 5 comments · Fixed by #1626

Comments

@michaelbull
Copy link
Contributor

Hi. I am using your package in conjunction with license-webpack-plugin. This plugin automatically fetches licensing information from packages and bundles all licenses into a single file for end-users. It does this by searching for the LICENSE file in your shipped package. For commercial reasons it's critical that I make your license available to my end-users.

Please can you consider shipping the LICENSE to the various npm packages via the files section of your package.json?

I have seen prior discussion in #546 however this was closed without ever including the LICENSE with the various shipped packages on npm.

Thanks in advance.

@atomiks
Copy link
Collaborator

atomiks commented Apr 15, 2022

The license in the monorepo root needs to be copied into every package

Shouldn't that plugin also just read from package.json? https://github.com/floating-ui/floating-ui/blob/master/packages/dom/package.json#L44

@michaelbull
Copy link
Contributor Author

michaelbull commented Apr 15, 2022

It does read from package.json to understand the license type, but not the license text. As such it is missing your author contributions and copyright inception year.

The MIT license within this repository states the following:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

Right now, copies of the software (+ substantial portions with the packages) are distributed onto npm without the above copyright notice, therefore violating the terms outlined within the MIT license.

For commercial reasons I need to ship all LICENSE texts for third-party libraries I use with the product that I am responsible for shipping to end-users, so I have had to manually copy the LICENSE file from this repo into mine and ship it.

@atomiks
Copy link
Collaborator

atomiks commented Apr 15, 2022

Is that the default for MIT licenses? Is there a license that is "do whatever the hell you want and don't include this license because it will increase your bundle size for no reason"? 😋

@FezVrasta
Copy link
Member

license collections are usually saved on a separate static text file and linked from the web app so they don't increase the bundle size.

@michaelbull
Copy link
Contributor Author

michaelbull commented Apr 15, 2022

Is that the default for MIT licenses?

Yes. Given the code in this repository is licensed as MIT, you have stated that you will include the above copyright notice in all copies of the software/significant portions.

For what it's worth, npm's package-size analysis on their website will not count LICENSE text.

license collections are usually saved on a separate static text file and linked from the web app so they don't increase the bundle size.

Yes, this is what I'm achieving with the license-webpack-plugin. I'm not suggesting to add the LICENSE text to the minified distribution files, just to the npm package itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants