fix: arrow hydration and svg offsetParent #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@floating-ui/dom (1.2.2 → 1.2.3)Bug Fixes
@floating-ui/react (0.20.0 → 0.20.1)Bug Fixes
Packages With No ChangesThe following packages have no user facing changes, so won't be released:
|
✅ Deploy Preview for vibrant-gates-22c214 canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding an example to the docs I found two problems:
platform.getOffsetParentshould returnwindow. If the floating element is inside a containing block, and is not itself a containing block, then the arrow is positioned relative to the containing block, not the floating element, which is wrong.styleprop that should be suppressed in case the floating element is initially rendered (likely hidden withvisibility: hidden). It seems like the React types don't have this prop onsvgelements but it works.