You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
popper.js publishes sourcemaps to NPM but the sources list in popper's sourcemap files points to a /src folder that's missing from NPM installs, because that folder is excluded by .npmignore.
This causes a few problems:
It's harder for users to navigate from source on GitHub to the corresponding source in their local dev environment, or vice-versa.
The source that users see during a debug session (which is the code stored in the source map file itself) is different from the bundled code that users see before or after a debug session. This difference leads to problems like confusion about where to set breakpoints (original source? bundle source? etc.), or difficulty setting breakpoints on first load (where the sourcemap source isn't available yet).
Tools that check for errors in source maps will report warnings if source files listed in the sourcemap aren't present on disk. I'm biased because I'm working on one of these tools now. ;-) FWIW, out of hundreds of NPM libraries that I've run through this tool, a few other libraries had the same problem, but they've all been fixed over the last few months.
I built a trivial PR #761 that adds /src to the .npmignore whitelist so that actual source will be included in the npm package. Let me know if there's any way I could help get this PR merged.
P.S. - Thanks for building popper.js... it's a great library! I use reactstrap heavily and although I've had lots of challenges with the Bootstrap parts, I've never had any problems with popups! ;-)
The text was updated successfully, but these errors were encountered:
popper.js publishes sourcemaps to NPM but the
sources
list in popper's sourcemap files points to a/src
folder that's missing from NPM installs, because that folder is excluded by.npmignore
.This causes a few problems:
I built a trivial PR #761 that adds
/src
to the.npmignore
whitelist so that actual source will be included in the npm package. Let me know if there's any way I could help get this PR merged.P.S. - Thanks for building popper.js... it's a great library! I use reactstrap heavily and although I've had lots of challenges with the Bootstrap parts, I've never had any problems with popups! ;-)
The text was updated successfully, but these errors were encountered: