From 548f6e33968b359f1a561ee5a87c2d815cca45c3 Mon Sep 17 00:00:00 2001 From: Kaspar Suvi Date: Tue, 29 Jan 2019 12:32:22 +0200 Subject: [PATCH 1/3] Fix padding types --- packages/popper/index.d.ts | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/popper/index.d.ts b/packages/popper/index.d.ts index 0d419b93f4..494d86714c 100644 --- a/packages/popper/index.d.ts +++ b/packages/popper/index.d.ts @@ -40,6 +40,13 @@ declare namespace Popper { 'x-placement': Placement; } + export interface Padding { + top: number, + bottom: number, + left: number, + right: number, + } + export interface BaseModifier { order?: number; enabled?: boolean; @@ -53,7 +60,7 @@ declare namespace Popper { }; preventOverflow?: BaseModifier & { priority?: Position[], - padding?: number, + padding?: number | Padding, boundariesElement?: Boundary | Element, escapeWithReference?: boolean }; @@ -63,7 +70,7 @@ declare namespace Popper { }; flip?: BaseModifier & { behavior?: Behavior | Position[], - padding?: number, + padding?: number | Padding, boundariesElement?: Boundary | Element, }; inner?: BaseModifier; From beb69a9cf3ade4d43a5c9aa1c3d35f4ca0645696 Mon Sep 17 00:00:00 2001 From: Kaspar Suvi Date: Tue, 29 Jan 2019 12:59:20 +0200 Subject: [PATCH 2/3] Fix padding TS types --- packages/popper/index.d.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/popper/index.d.ts b/packages/popper/index.d.ts index 494d86714c..a17dee74c2 100644 --- a/packages/popper/index.d.ts +++ b/packages/popper/index.d.ts @@ -41,10 +41,10 @@ declare namespace Popper { } export interface Padding { - top: number, - bottom: number, - left: number, - right: number, + top?: number, + bottom?: number, + left?: number, + right?: number, } export interface BaseModifier { From f72679de104c8e5f72458ea89c1e272aae234977 Mon Sep 17 00:00:00 2001 From: Kaspar Suvi Date: Tue, 29 Jan 2019 13:00:49 +0200 Subject: [PATCH 3/3] Fix padding Flow types --- packages/popper/index.js.flow | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/packages/popper/index.js.flow b/packages/popper/index.js.flow index 800eeef513..5ca317f46c 100644 --- a/packages/popper/index.js.flow +++ b/packages/popper/index.js.flow @@ -51,6 +51,13 @@ declare module 'popper.js' { declare type ModifierFn = (data: Data, options: Object) => Data; + declare type Padding = { + top?: number, + bottom?: number, + left?: number, + right?: number, + } + declare type BaseModifier = { order?: number, enabled?: boolean, @@ -64,7 +71,7 @@ declare module 'popper.js' { }, preventOverflow?: BaseModifier & { priority?: Position[], - padding?: number, + padding?: number | Padding, boundariesElement?: Boundary | Element, escapeWithReference?: boolean, }, @@ -74,7 +81,7 @@ declare module 'popper.js' { }, flip?: BaseModifier & { behavior?: Behavior | Position[], - padding?: number, + padding?: number | Padding, boundariesElement?: Boundary | Element, }, inner?: BaseModifier,