Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks can't be synchronized and show "Scheduled" #1548

Closed
1 task done
Ganya-A opened this issue Feb 21, 2024 · 41 comments · Fixed by #1571 or #1598
Closed
1 task done

Bookmarks can't be synchronized and show "Scheduled" #1548

Ganya-A opened this issue Feb 21, 2024 · 41 comments · Fixed by #1571 or #1598

Comments

@Ganya-A
Copy link

Ganya-A commented Feb 21, 2024

Which version of floccus are you using?

5.0.8 5.0.9

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Edge

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

jianguoyun

Describe the Bug

I can't get both of my computers to sync.
Scheduled:This profile will be synced soon. We're either waiting for other devices of yours, or other profiles on this device, to finish syncing.

Expected Behavior

To Reproduce

Debug log provided

  • I have provided a debug log file
@Ganya-A Ganya-A added the bug label Feb 21, 2024
@github-actions github-actions bot added this to Backlog in Floccus Feb 21, 2024
Copy link

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus and have been maintaining it ever since.
I currently work for Nextcloud which leaves me with less time for side projects like this one
than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

@Syzygy33
Copy link

Which version of floccus are you using?

5.0.8 5.0.9

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Edge

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

jianguoyun

Describe the Bug

I can't get both of my computers to sync. Scheduled:This profile will be synced soon. We're either waiting for other devices of yours, or other profiles on this device, to finish syncing.

Expected Behavior

To Reproduce

Debug log provided

  • I have provided a debug log file

try to delete the .lock file

@Ganya-A
Copy link
Author

Ganya-A commented Feb 29, 2024

Which version of floccus are you using?

5.0.8 5.0.9

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Edge

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

jianguoyun

Describe the Bug

I can't get both of my computers to sync. Scheduled:This profile will be synced soon. We're either waiting for other devices of yours, or other profiles on this device, to finish syncing.

Expected Behavior

To Reproduce

Debug log provided

  • I have provided a debug log file

try to delete the .lock file

After deleting the. lock file, it will appear soon.

@Syzygy33

This comment was marked as off-topic.

@marcelklehr
Copy link
Member

Please make sure

  • that all your Floccus instances on Chrome (or variants thereof, like Edge, Brave, Vivaldi etc.) are on v5.0.9
  • that all your Floccus instances on Firefox are on v5.0.8

Judging from the chrome webstore statistics there are still around 800 Chrome instances on v5.0.6, which has this bug.

@marcelklehr marcelklehr moved this from Backlog to Triaging in Floccus Mar 3, 2024
@Ganya-A
Copy link
Author

Ganya-A commented Mar 8, 2024

请确保

  • 您在 Chrome 上的所有 Floccus 实例(或其变体,如 Edge、Brave、Vivaldi 等)都在 v5.0.9 上
  • Firefox 上的所有 Floccus 实例都在 v5.0.8 上

从 chrome 网店统计来看,v5.0.6 上还有大约 800 个 Chrome 实例,存在此 bug。

I've updated all device versions to 5.0.9, two EDGE, and one mobile browser, and I'm still having this problem.

marcelklehr added a commit that referenced this issue Mar 8, 2024
see #1548

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr
Copy link
Member

marcelklehr commented Mar 8, 2024

So, this should only really be a problem when syncing via WebDAV like @Ganya-A and @idzyr and @beyercj

@InfamousUser is syncing via Nextcloud Bookmarks, which should automatically timeout its lock. Is this still happening for you?

@traviss64 are you syncing via Nextcloud Bookmarks or via Nextcloud files (ie. webdav)?

@marcelklehr marcelklehr mentioned this issue Mar 8, 2024
1 task
@idzyr
Copy link

idzyr commented Mar 9, 2024

@marcelklehr
I have the same issue as the original post, but I'm using a PC with Chrome(v122.0.6261.112). I tried deleting the lock file, but after a while, it stops working again.

@marcelklehr
Copy link
Member

This should be resolved with v5.0.10, please let me know if it works :)

@InfamousUser
Copy link

Updated to v5.0.10 on Chrome, no change.

@beyercj
Copy link

beyercj commented Mar 11, 2024

Updated to v5.0.10 on Firefox 115.8.0esr for Linux and to v5.0.11 on Android 11 on Samsung Galaxy A12, no change either on webdav.smartdrive.web.de (webspace almost full). However, synchronisation worked fine on webdav.vodafonemail.de (webspace almost empty), so might not have anything to do with floccus.

@marcelklehr marcelklehr changed the title Bookmarks can't be synchronized and show“Scheduled” Bookmarks can't be synchronized and show "Scheduled" Mar 12, 2024
@marcelklehr
Copy link
Member

So, this issue usually stems from a leftover lock file that prevents all clients from syncing. v5.0.10 should mitigate that by forcing floccus to sync anyway, if it has waited long enough. If this does not fix this for you all, then we might have a more serious issue of an interrupted sync process. This would be the case if for example if floccus does sometimes start to sync but then stops, likely after about 5mins, only to then show the "scheduled Sync" message one minute later, which again stems from the leftover lock file. On firefox I think you can also verify if this is the problem by opening the browser debug log. The browser will then no longer interrupt the sync process and thus floccus should sync correctly after some time waiting for the lock to expire and go back to an "All good" green status, while the debug window is open.

Here's how to open the debug window:

Firefox

  • Go to about:debugging
  • Go to This firefox
  • click on debug button next to floccus entry to open the console

Not sure, if this will work in chrome, but you may try:

Chrome

  • Go to chrome://extensions
  • enable Developer mode
  • click on dist/html/background.html button in floccus' entry next to "Inspect views: " to open the console

@InfamousUser
Copy link

I am receiving "QUEUING POST", "FETCHING POST", "Receiving response for POST" and then "Resource is locked, trying again soon" in the Floccus logs. I should note that it did sync the folders to the server, but none of the actual bookmarks are populated.

@marcelklehr
Copy link
Member

@InfamousUser You will need to wait until the lock is cleared for the above thing with the debug window to work. Only unpopulated folders is a bad sign, though...

@InfamousUser
Copy link

How long do I need to wait? Sever has been off for the past few days, I just turned it on and still the same problem. Is there a way to force this or what am I supposed to do?

@marcelklehr
Copy link
Member

Doesn't matter anymore, I've been able to reproduce this now and can debug from there. It looks like Chrome blatantly shuts down extension service workers after running some amount of minutes. There's not gonna be an easy fix for this, I think. Should still be doable though

@smth
Copy link

smth commented Mar 29, 2024

I also have this problem. Two Firefox browsers using v5.0.10 (though one was recently on 5.0.5). My server does have a lock file on it.

@cng10001
Copy link

cng10001 commented Apr 3, 2024

I also have this problem. Two Firefox browsers using v5.0.10 (though one was recently on 5.0.5). My server does have a lock file on it.

Add a new account and use other ways of sync for now.Hope the author solve the problem soon.

@truthsword
Copy link

Updated Firefox from 5.0.8 to 5.0.10 and within a short time the lock file imposed itself. Is rollback possible? I deleted the lock file, but can't do that regularly. I'm using WebDAV.

@cng10001
Copy link

cng10001 commented Apr 3, 2024

Updated Firefox from 5.0.8 to 5.0.10 and within a short time the lock file imposed itself. Is rollback possible? I deleted the lock file, but can't do that regularly. I'm using WebDAV.

I delete the lock file ,then remove my account and re-add it. You can try this too, no loss anyway

@truthsword
Copy link

truthsword commented Apr 3, 2024

I delete the lock file ,then remove my account and re-add it. You can try this too, no loss anyway

No need to remove account. Disable all Floccus extensions. Delete lock file. Enable all Floccus extensions. Not something one wants to do multiple times a day.

@marcelklehr marcelklehr reopened this Apr 6, 2024
Floccus automation moved this from Done to Backlog Apr 6, 2024
@marcelklehr
Copy link
Member

marcelklehr commented Apr 6, 2024

Hello everyone, there's now a beta release available which should fix this issue: https://github.com/floccusaddon/floccus/releases/tag/v5.0.12-beta.1

Firefox

On firefox you should be able to install this by

  • Unzipping the firefox build somewhere
  • Going to about:debugging -> "This Firefox" -> Load temporary extension -> and selecting the unzipped folder

Chrome

On chrome you should be able to install this by

  • Unzipping the chrome build somewhere
  • Going to chrome://extensions
  • Enabling developer mode
  • Click "Load unpacked" -> select the manifest.json from the unzipped folder

Android

On android you should be able to install this by

  • Opening the apk or aab build, if you previously installed floccus from Google Play or Github
  • (If you installed from f-droid, you'll need to uninstall unfortunately, because f-droid has its own set of keys)

Important

  • Please make a backup of your bookmarks before trying this out!

Let me know how it goes ✌️

@marcelklehr marcelklehr moved this from Backlog to In progress in Floccus Apr 6, 2024
@cng10001
Copy link

cng10001 commented Apr 8, 2024

Hello everyone, there's now a beta release available which should fix this issue: https://github.com/floccusaddon/floccus/releases/tag/v5.0.12-beta.1

Firefox

On firefox you should be able to install this by

  • Unzipping the firefox build somewhere
  • Going to about:debugging -> "This Firefox" -> Load temporary extension -> and selecting the unzipped folder

Chrome

On chrome you should be able to install this by

  • Unzipping the chrome build somewhere
  • Going to chrome://extensions
  • Enabling developer mode
  • Click "Load unpacked" -> select the manifest.json from the unzipped folder

Android

On android you should be able to install this by

  • Opening the apk or aab build, if you previously installed floccus from Google Play or Github
  • (If you installed from f-droid, you'll need to uninstall unfortunately, because f-droid has its own set of keys)

Important

  • Please make a backup of your bookmarks before trying this out!

Let me know how it goes ✌️

It seems the problem still exits
emm

@marcelklehr
Copy link
Member

@cng10001 You will still need to wait or remove the lock manually, initially, as described above. Afterwards it shouldn't get stuck like this anymore.

@marcelklehr
Copy link
Member

Any other testers? Would be great if a few of you could test this, otherwise I have to release it untested :S

@InfamousUser
Copy link

InfamousUser commented Apr 14, 2024

Well, unlike the previous version, this one did manage to sync something. It synced around 150 bookmarks before going to the "Scheduled" stage and stopping there. Errors in the log are identical to the post #1548 (comment) or being E017 network error which changes to the "This profile will be synced soon..." one upon depressing the sync now button.

It is periodically switching between syncing and scheduled with syncing only for a few seconds but no additional bookmarks being synced.

@marcelklehr
Copy link
Member

@InfamousUser Thank you for taking it for a spin! Are there any other floccus instances running that haven't been updated to the beta version, yet?

@InfamousUser
Copy link

@InfamousUser Thank you for taking it for a spin! Are there any other floccus instances running that haven't been updated to the beta version, yet?

There is the original Floccus, the beta doesnt update it but make an additional extension unfortunately. It had its autosync disabled though and hasn't synced as far as I'm aware and the last error in its log is 17.03.2024. I can delete it if you think it's interfering in some way?

@marcelklehr
Copy link
Member

Mh, probably best to disable the original extension instance, yeah

@InfamousUser
Copy link

InfamousUser commented Apr 14, 2024

I disabled the real extension in settings. It seems to be randomly syncing more bookmarks but this is not what I would call a working fix. It has synced another 100 or so bookmarks. When you press the sync it latches but then it keeps switching between syncing and scheduled. Bu then after a while it "finishes" and you have to trigger it again because it has not synced the bookmarks.

@cng10001
Copy link

@cng10001 You will still need to wait or remove the lock manually, initially, as described above. Afterwards it shouldn't get stuck like this anymore.

Maybe my problem is I was still using a lower version of chrome,
I updated the browser and I'll watch it for more days

@marcelklehr
Copy link
Member

marcelklehr commented Apr 21, 2024

@InfamousUser Can you confirm whether it syncs for roughly 5 minutes, at least, before it switches back to "scheduled"?

@marcelklehr
Copy link
Member

marcelklehr commented Apr 21, 2024

Chrome version may be interesting as well, indeed. Chrome v110+ may be necessary for some of this to work properly

@InfamousUser
Copy link

I do not and cannot have Chrome v110+ due to Google blocking updates on older Windows so count me out for testing that...

@marcelklehr
Copy link
Member

Oh Wow! So you do have pre v110 Chrome, so the fix I built may work after all. Sorry about the Chrome updates!

@InfamousUser
Copy link

Geez, never thought that'd be the issue! I can try it on a different PC, with newer browser, but I have a feeling that will work since it doesn't really help! Will get back to you with the results!

@marcelklehr
Copy link
Member

It's not the root cause, but part of my fix only works post v110

@marcelklehr
Copy link
Member

Alright, since it works for me I'll roll this out stage-wise in production now to get people to test it.

@marcelklehr
Copy link
Member

Staged roll-out failed for some reason, so now this is on prod 100% 🙈
Anyway. @Ganya-A and @idzyr and @beyercj Are you on v5.0.12 already? Does it work now after removing the lock file manually once?

marcelklehr added a commit that referenced this issue May 9, 2024
fixes #1594
fixes #1548

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Floccus automation moved this from In progress to Done May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
9 participants