Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter warnings still displayed in IDE when "flow.coverageSeverity": "error" #382

Open
carlost opened this issue Apr 6, 2020 · 1 comment

Comments

@carlost
Copy link

carlost commented Apr 6, 2020

Sorry if I am spamming this repo with issues ... i suspect a lot of this is just me not RTFM.

Running:

  • Flow Language Support v1.5.0
  • Visual Studio Code Version: 1.43.2
  • Flow v0.105.2 (I am stuck to this version of flow because of the version of react-native I am using)

I am running flow extension in LSP mode and have it configured to only display errors:

	"flow.useLSP": true,
	"flow.useBundledFlow": false,
	"flow.useNPMPackagedFlow": false,
	"flow.pathToFlow": "${workspaceFolder}/client/node_modules/.bin/flow",
	// "flow.useLSP": false, // old and busted flow doesn't support LSP
	// the NON LSP code in the flow extension expands ${workspaceRoot} and not
	// ${workspaceFolder} to the workspace root dir
	// "flow.pathToFlow": "${workspaceRoot}/client/node_modules/.bin/flow",
	"flow.logLevel": "info",
	"flow.stopFlowOnExit": false,
	"flow.coverageSeverity": "error",

VS Code still displays linter warnings even when "flow.coverageSeverity" is set to "error"

When i run yarn flow status without requesting warnings, the output does not include any lint warnings. When i run yarn flow status --include-warnings --show-all-errors all of the flow IDE output appears to be identical to the output from flow status.

I tried to compare how the FlowLanguageClient in the extension was configured vs what the flow LSP expected ... but i couldn't make heads or tails of that code base.

@Mayank1791989
Copy link
Contributor

Mayank1791989 commented Apr 18, 2020

@carlost Are you talking about the flow-lint warning? If you want to hide them, then use include_warnings option in .flowconfig. flow.coverageSeverity option is to change the severity level of only coverage warnings (in flow coverage and lint are separate things).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants