Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension crashes if flow.trace.server is not a string #402

Open
jvilk-stripe opened this issue Oct 20, 2020 · 0 comments
Open

Extension crashes if flow.trace.server is not a string #402

jvilk-stripe opened this issue Oct 20, 2020 · 0 comments

Comments

@jvilk-stripe
Copy link

jvilk-stripe commented Oct 20, 2020 •
edited

Steps to reproduce

  1. Add flow.trace.server: null to your VS Code settings.
  2. Restart VS Code.
  3. Open a JS file. Flow will fail to start. The log shows a type error in fromString.

Expected result

Flow ignores the invalid setting.

The issue appears to be in the LanguageClient library. From the minified source, I cannot tell if it has been fixed upstream:

https://github.com/microsoft/vscode-languageserver-node/blob/084c035af6aeb2999df7d26eb69f3b34acae9ca8/client/src/common/client.ts#L3339
@jvilk-stripe jvilk-stripe changed the title Extension crashes if trace.server is not a string Extension crashes if flow.trace.server is not a string Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jvilk-stripe