Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3884 Expression language support for conditional sequence flow and conditional events #3889

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#3884 Expression language support for conditional sequence flow and conditional events #3889

wants to merge 1 commit into from

Conversation

rasmusfaber
Copy link

This fixes #3884 by adding support for other expression languages as specified by the language tag in the FormalExpression, i.e.

   <sequenceFlow id="flow">
      <conditionExpression xsi:type="tFormalExpression" language="groovy">
          customer.addresses.any { it.country == 'US' }
      </conditionExpression>
    </sequenceFlow>

Check List:

  • Unit tests: YES
  • Documentation: NA (I couldn't find anything at least)

rasmusfaber
rasmusfaber commented May 14, 2024
View reviewed changes
...e-engine-common/src/main/java/org/flowable/common/engine/impl/el/ScriptEngineExpression.java
}

private ScriptingEngines getScriptingEngines() {
CommandContext commandContext = Context.getCommandContext();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you prefer a different way to get the dependency? But this looks like the way it is done elsewhere, except they mostly use CommandContextUtil (which is not accesible from flowable-engine-common).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conditions should support more than JUEL expressions
1 participant
@rasmusfaber