How does this handles large number of functions?

[vicary]

I am new to esbuild, so this discussion maybe in a grey area between serverless-esbuild and esbuild.

I have an AppSync project in production that contains 300-ish lambdas resolvers in TypeScript, still growing.

With webpack I have to throttle the concurrency with thread-loader, fork-ts-checker-webpack-plugin, fork-ts-checker-webpack-plugin-limiter and my own PR serverless-heaven/serverless-webpack#681 to modify webpack a little bit in order to work.

I believe 300 entries is not a normal use case for any kind of bundlers, but AppSync just creates such an extreme play.

Do you think serverless-esbuild is able to handle 300 entries out of the box?

If not, can it handle them with plugins and/or configurations?

[olup]

No idea, but I'd be interested in the results if you try serverless-esbuild with your setup. Le jeu. 15 juil. 2021 à 16:31, Vicary A. ***@***.***> a écrit :

…

I am new to esbuild, so this discussion maybe in a grey area between serverless-esbuild and esbuild. I have an AppSync project in production that contains 300-ish lambdas resolvers in TypeScript, still growing. With webpack I have to throttle the concurrency with thread-loader, fork-ts-checker-webpack-plugin, fork-ts-checker-webpack-plugin-limiter and my own PR serverless-heaven/serverless-webpack#681 <serverless-heaven/serverless-webpack#681> to modify webpack a little bit in order to work. I believe 300 entries is not a normal use case for any kind of bundlers, but AppSync just creates such an extreme play. Do you think serverless-esbuild is able to handle 300 entries out of the box? If not, can it handle them with plugins and/or configurations? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#164>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADJFT5HU4SQKLFOVEDRX7PDTX3WMRANCNFSM5ANVUJLQ> .

[vicary]

You may see my result in the comment below #164 (reply in thread)

[floydspace]

I think esbuild itself is capable to handle bundling 300+ entries at the same time, because fast bundling is in the blood of esbuld. But I'm not sure if our external modules packaging logic would handle it. I would definitely suggest trying theserverless-esbuild with or without packaging externals. Really curious about the results.

[vicary]

jeesh motherly love of god

In my webpack setup it was 50-80 seconds per entry (with type checking), with esbuild it is 2 secs per entry. Looks like it's made with concurrencies in mind, the resulting time of the whole build process reduced from 30 mins to 3.5 mins!

If anything else it's the type checking I have to take care of, probably hook into my test pipelines and call it a day.

I have to admit this is a very promising result!

[floydspace]

Happy to hear it works, do not hesitate to make a PR to serverless-esbuild, any contribution is appreciated.

[vamche]

Sorry but I'm not really sure how to force an exclusion on all node_modules, shall I make use of the packagePath option to a fake package.json without any dependencies?

FYI, you can use esbuild.packagerOptions.scripts to exclude node_modules from the final artefact.

  packagerOptions:
      scripts:
        - rm -rf node_modules

[floydspace]

yes, but it's better just not create the node_modules at all, otherwise, it's just wasting time

[vicary]

I was using @esbuild-plugins/node-resolve to exclude it.

Tried not using that to see final bundle size, esbuild simply refuse to run. It hangs for 2 minutes then crash with the message "Service is stopped."

I guess it is about exceeding heap size limit but there is no internal stack trace for me.

[floydspace]

@vicary Also, as a side suggestion, you could try using esbuild-loader with your webpack setup and see how it handles your project. it must increase your lambdas bundling speed

[vicary]

I actually tried this one. It halves the build time for each entry for my other smaller projects, with around 50 lambdas on average. But, sadly, for the big project with 300 entries it makes no difference.