emit_count_metrics has wrong name

[danielhoherd]

Describe the bug

While digging through code I think I found a bug where emit_count_metrics has the wrong metrics_create name.

fluentd/lib/fluent/plugin/bare_output.rb

Lines 73 to 74 in b28f7d7

	@emit_count_metrics = metrics_create(namespace: "fluentd", subsystem: "bare_output", name: "emit_records", help_text: "Number of count emits")
	@emit_records_metrics = metrics_create(namespace: "fluentd", subsystem: "bare_output", name: "emit_records", help_text: "Number of emit records")

Both emit_count_metrics and emit_records_metrics call metrics_create(namespace: "fluentd", subsystem: "bare_output", name: "emit_records") with just different help_text. It seems like emit_count_metrics should have the name emit_count.

To Reproduce

Look at

fluentd/lib/fluent/plugin/bare_output.rb

Lines 73 to 74 in b28f7d7

	@emit_count_metrics = metrics_create(namespace: "fluentd", subsystem: "bare_output", name: "emit_records", help_text: "Number of count emits")
	@emit_records_metrics = metrics_create(namespace: "fluentd", subsystem: "bare_output", name: "emit_records", help_text: "Number of emit records")

This also shows up in a few more places.

Expected behavior

Honestly, I expected fluentd_output_status_emit_count and fluentd_output_status_emit_records from the prometheus plugin to not look identical, which took me down a rabbit hole and led me here.

Your Environment

N/A, just digging through code

Your Configuration

k8s 1.21 in GKE

Your Error Log

N/A

Additional context

No response

[kenhys]

@danielhoherd thank you for reporting!

Fixed via #3630