Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to FluentAssertions v6 #42

Open
rikrak opened this issue Nov 2, 2021 · 4 comments
Open

Upgrade to FluentAssertions v6 #42

rikrak opened this issue Nov 2, 2021 · 4 comments

Comments

@rikrak
Copy link
Contributor

rikrak commented Nov 2, 2021

Updating my project to the latest FluentAssertions library causes runtime errors:
System.MissingMethodException: Method not found: 'Void FluentAssertions.Primitives.ReferenceTypeAssertions`2.set_Subject(!0)'.
at FluentAssertions.Mvc.ActionResultAssertions..ctor(ActionResult subject)
at FluentAssertions.Mvc.AssertionsExtensions.Should(ActionResult actual)

This is due to v6 having some breaking changes, specifically around how the Assertions base classes are constructed

@kevinkuszyk
Copy link
Member

@rikrak apologies again with the delay on this.

As you can probably tell, I'm not spending much time in the .net space at the moment. As you've been the most active contributor here, how would you feel about coming on board as a maintainer?

And on that subject, we're going to need to ship a new version with this in. Would you mind to open another PR which bumps the version to 0.9.0. Once that's in, I'll cut a new release to NuGet.

@rikrak
Copy link
Contributor Author

rikrak commented Nov 20, 2021

Maintainer? Yep, can do. Let me know if there are any rules and such

I think the version is already at v0.9.0. I'm going off memory here though.

@rikrak
Copy link
Contributor Author

rikrak commented Nov 20, 2021

Yep it's at v0.9.0 already

[assembly: AssemblyVersion("0.9.0")]

@rikrak
Copy link
Contributor Author

rikrak commented Nov 27, 2021

@kevinkuszyk is there anything else you need before package release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants