ClearExpectation after Given<> always returns false

[eNeRGy164]

Description

ClearExpectation() returns false after a successful Given<>.

Complete minimal example reproducing the issue

bool success = Execute.Assertion
    .Given(() => new object())
    .ForCondition(subject => true)
    .FailWith("but collection is <null>.")
    .Then
    .ClearExpectation();

success.Should().BeTrue();

Expected behavior:

Should return true.

Actual behavior:

Returns false

Having another Given(() => {}).ForCondition() chain after ClearExpectation will return true again.

Versions

• 6.0 beta (source)
• Any

[eNeRGy164]

I'm investigating this and finding all kinds of methods that are not completely following the continuation logic as expected.

Expect incoming unit tests on AssertionScope, ContinuedAssertionScope and GivenSelector 😅

[eNeRGy164]

The root cause of this issue is not easily fixable without breaking changes I think.
It comes down to the fact that the return value of an AssertionScope is only reliable if FailWith is the last method in the chain. Every next method can't know the state of the scope as it's an internal value (Nullable<bool>) that is reset after every failure.
Every continuation needs this value as input, but it's not queryable as it is immediately reset to null.
That means that ClearExpectation needs to know if the chain is in a failure or successful flow, the scope status will be null. This could be seen as successful (not false, so no failure), but that would also mean it can't return false when it was actually preceded by a failure.

[dennisdoomen]

Then I'll need to dive into this when I have time again.