Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare what files should be considered as source and documentation #2098

Closed
ITaluone opened this issue Jan 13, 2023 · 6 comments · Fixed by #2100
Closed

Declare what files should be considered as source and documentation #2098

ITaluone opened this issue Jan 13, 2023 · 6 comments · Fixed by #2100
Labels
building Building and Infrastructure of Fluent Assertions triage

Comments

@ITaluone
Copy link
Contributor

ITaluone commented Jan 13, 2023

Description

Now I think there is a slight inconsistency of what files are considered as source and documentation changes.

For example: only files inside the docs folder considered as documentation changes and triggers a spell check, and any other files (e.g. .github/*, CONTRIBUTING.md, cSpell.json,...) are considered as source change.

I propose a more detailed way of this consideration.

Source changes:
.nuke/**/*
Build/**/*
Src/**/*
Tests/**/*
build.*
CNAME
Directory.Build.props
FluentAssertion.sln
FluentAssertion.sln.DotSettings
GitVersion.yml
global.json
nuget.config
Rules.ruleset
TestRules.ruleset

Documentation changes:
docs/**/*
CONTRIBUTING.md
cSpell.json
LICENSE
README.md

@jnyrup
Copy link
Member

jnyrup commented Jan 13, 2023

Would it be easier to define documentation as you proposed (or similar) and everything else as source?

I'm trying to avoid:

  • having to maintain this list and
  • pipelines not being run because I missed that I e.g. added a source file not on the list.

@IT-VBFK
Copy link
Contributor

IT-VBFK commented Jan 13, 2023

If you can live with running the build even when only the build.yml is changed..

@IT-VBFK
Copy link
Contributor

IT-VBFK commented Jan 13, 2023

Can I add that to #2093?

@dennisdoomen
Copy link
Member

Would it be easier to define documentation as you proposed (or similar) and everything else as source?

I'm trying to avoid:

  • having to maintain this list and
  • pipelines not being run because I missed that I e.g. added a source file not on the list.

I agree with @jnyrup here. I don't even care if the build runs too often and I most definitely want to maintain a list.

@IT-VBFK
Copy link
Contributor

IT-VBFK commented Jan 13, 2023

Cool will do that..

Can I add that to #2093?

If this is ok, I will add this few lines to this PR?

@jnyrup
Copy link
Member

jnyrup commented Jan 14, 2023

Cool will do that..

Can I add that to #2093?

If this is ok, I will add this few lines to this PR?

No, please.
It's much easier for us to manage and review more PRs that have a narrower focus.

@dennisdoomen dennisdoomen added building Building and Infrastructure of Fluent Assertions and removed bug labels Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Building and Infrastructure of Fluent Assertions triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants