New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Use reference to System.Net.Http using framework Reference
instead of PackageReference
#2120
Comments
Is this related to #1806? |
@eNeRGy164 if you ask me, I can say that changes from PR will solve my problem, but #1805, was more about linux runtime and framework 4.8. Definitely final solution mention in last comment will not works for me. |
Just to get a more complete understanding. |
@jnyrup yes that cause real problem for some of my projects that based on 4.7.2. |
Alright 👍 |
Just read through all the references, and it seems to be a valid problem. Even Claire Novotny was pulled in to help the IdentityModel folks understand this. My only concern is how this affects existing code bases that would upgrade. |
Is this a coincidence? #2121 |
I am wondering why some of the .NET 4.7.2 projects I've been involved with didn't have that problem. |
Could you try this NuGet package (it's wrapped in an |
Instead, @AArnott produced an even better PR. So can you try this NuGet package? |
@dennisdoomen This is an amazing coincidence. |
I had to pull in one of Microsoft's MSBuild team engineers to understand it. :) (and I used to be on the MSBuild team myself!) |
sorry, I wasn't able to answer during the weekend. @dennisdoomen @AArnott I have take a look at #2122 - looks sensible to me and what is more import, the attached pre-release version solved my issues. To be honest I do not fully understand why msbuild resolved I agree that it is insane coincidence :) |
Fixed with 97cf195? |
Background and motivation
I hope this is the correct place to raise this.
Currently for .net47 target you are adding reference to
System.Net.Http
as package dependency:According to this issue dot net team advise adding
System.Net.Http
standard framework reference instead. Just quoting them:The main reason why I am suggesting this change is that VisualStudio resolve 4.7.2 project dependency to
System.Net.Http
and all its System dependencies by adding references to .net framework installed on local machine instead of project nuget. I think this issue has been raise in multiple place e.g. Broken System.Net.Http 4.1.1-4.3.0 post-mortem . It can also be problematic when you have reference to same assembly with both a single name reference and a package reference. For more details please take a look on Single-name references are removed by the SDK when targeting .NET Framework 4.7.2 and referencing a package with the same assemblyAlternative Concerns
Could you consider changing above to something like:
It looks like another few other projects decide to follow this advise e.g. IdentityModel, Microsoft Graph
The text was updated successfully, but these errors were encountered: