Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeInDescendingOrder broken in 6.9.0+ #2216

Closed
jrod567 opened this issue Jun 9, 2023 · 4 comments
Closed

BeInDescendingOrder broken in 6.9.0+ #2216

jrod567 opened this issue Jun 9, 2023 · 4 comments

Comments

@jrod567
Copy link

jrod567 commented Jun 9, 2023

Description

In FA v6.8.0 and lower, the BeInAscendingOrder/BeInDescendingOrder assertions behavior works as expected. In version v6.9 through current v6.11, the same code is now failing.

Reproduction Steps

List mylist = new List
{ "ZTK Zapp", "YHTest", "Yellow Bird 1", "gw" };
mylist.Should().BeInDescendingOrder(); //Pass in v6.8/v6.7; Fail in v6.9-6.11

Expected behavior

I expected the same list to pass this test in current versions

Actual behavior

Fails unexpectedly

Regression?

Yes - Pass in v6.8, v6.7. Failure started in v6.9 through v6.11

Known Workarounds

No response

Configuration

No response

Other information

No response

@IT-VBFK
Copy link
Contributor

IT-VBFK commented Jun 9, 2023

Probably #2075

Issues:
#2126
#2109

@jrod567
Copy link
Author

jrod567 commented Jun 12, 2023

Thanks - so specifying the current culture will bypass the (now) default ordinal comparer, assuming I understood the original issue. For example:

mylist.Should().BeInDescendingOrder(StringComparer.CurrentCulture); //works in FA 6.9+

@dennisdoomen
Copy link
Member

I think we can close this one, right?

@jrod567
Copy link
Author

jrod567 commented Jul 17, 2023

Yep - closing!

@jrod567 jrod567 closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants