Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the various linters to be configured via their standard config files #16

Open
jobara opened this issue Oct 1, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@jobara
Copy link
Member

jobara commented Oct 1, 2020

Is your feature request related to a problem?

It might be easier for a user of fluid-grunt-lint-all to be able to use the standard config files, e.g. eslintrc.json and etc. to configure the settings of the various fluid-grunt-lint-all plugins. IDEs can already be setup to use these configuration files to provide linting during coding/writing. Also, it may be clearer for those coming into the project to understand what and where to find the configuration.

Describe the solution you'd like

Use standard configuration files for the various linters, instead of configuring through grunt, although that could still be an option for overrides if necessary.

Additional context or notes

Config file changes coming to eslint: eslint/rfcs#9

@the-t-in-rtf
Copy link
Collaborator

the-t-in-rtf commented Oct 6, 2020

As we've discussed elsewhere, some ESLint settings overlap with settings specific to Grunt (notably, which files to include/exclude). We need a strategy for dealing with this overlap. There is also the option to specify that an entirely different configuration file should be used. If we're going to keep using grunt-eslint, whatever we come up with has to ensure that we don't special case the configuration file names we prefer in a way that limits people's options to use different names or conventions.

Longer term, we also need to discuss this in combination with moving away from Grunt, which I've filed as #21

The simplest change for now might be to simply use the configFile option more widely. We should at least review the plugins we use and see whether they have a configFile option, and if so, whether we can make them better aware of our settings files by adding settings.

@the-t-in-rtf
Copy link
Collaborator

As mentioned in #21, we also support our own syntax for includes and excludes, so if we start respecting central configuration files, we'd either need to update that support, or perhaps follow a strategy like React's scripts, where they disallow the use of particular configuration options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants