Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make color picker use v-model and propsync #1375

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

pedrolamas
Copy link
Member

@pedrolamas pedrolamas commented Feb 26, 2024

This PR refactors the AppIroColorPicker and AppColorPicker to use v-model and propsync where possible, thus making the control easier to consume, and fixing the reported issue.

Note: following up on what we already do with our custom input controls, changing the value on the text input boxes will not take effect unless Enter is pressed.

Fixes #1372

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas pedrolamas added the GH - Bug Something isn't working label Feb 26, 2024
@pedrolamas pedrolamas added this to the 1.28.2 milestone Feb 26, 2024
@pedrolamas
Copy link
Member Author

@matmen I know you also have an incoming PR with work on this area, I made it easy to integrate your changes in this one (just by using the new currentRed, currentGreen, currentBlue and currentWhite props)

Copy link
Member

@matmen matmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened a PR on your repo that fixes the color settings not applying in the metrics settings, otherwise these changes LGTM

Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
@pedrolamas
Copy link
Member Author

Oops, I forgot to change those @change to @input... I just send a new commit da41abe that from me tests fixes the issue!

@pedrolamas pedrolamas merged commit 4f6198f into fluidd-core:develop Feb 28, 2024
4 checks passed
@pedrolamas pedrolamas deleted the pedrolamas/fix-1372 branch February 28, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GH - Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fluidd resends SET_LED commands if led color is changed by macro or console command
2 participants