Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Flutter outline #7398

Closed
kenzieschmoll opened this issue May 2, 2024 · 9 comments
Closed

Remove the Flutter outline #7398

kenzieschmoll opened this issue May 2, 2024 · 9 comments
Milestone

Comments

@kenzieschmoll
Copy link
Member

The IntelliJ Structure view provides this functionality so we do not need to maintain our own.

@helin24
Copy link
Member

helin24 commented May 9, 2024

The main difference I see after looking at a few files is having some "wrap with..." buttons here:
Image

I don't see this functionality available elsewhere, but are we okay with not having this any more?

CC @jwren

@jwren
Copy link
Contributor

jwren commented May 9, 2024

Yes, this issue was opened when we thought there was no difference in functionality between the Structure view and the Flutter Outline. I suspect that with time functionality like this might come from DevTools and DTD, but for the time being, we should not remove it.

@helin24
Copy link
Member

helin24 commented May 9, 2024

Okay, thanks for clarifying. For future reference, another thing that I found that is part of the flutter outline is this inline editing panel: #4160

@kenzieschmoll
Copy link
Member Author

kenzieschmoll commented May 9, 2024

I don't see this functionality available elsewhere, but are we okay with not having this any more?

These functions are all available as quick fixes, so I don't think the actions at the top should be a blocker to remove.

Screenshot 2024-05-09 at 3 27 03 PM

@kenzieschmoll
Copy link
Member Author

Also, the outline view doesn't seem to load for me. We should add analytics to this view to see if many users are using it:
Screenshot 2024-05-09 at 3 31 11 PM

@kenzieschmoll
Copy link
Member Author

Also, the outline view doesn't seem to load for me

Ah, looks like this view is configured to only be enabled when there is a running app, which is a bug. The outline view + Hot UI for that matter should work with now connected app.

@helin24
Copy link
Member

helin24 commented May 10, 2024

We do have data on the usage of the outline, last week numbers below:

  • 1,000 unique users
  • 8,200 usages of jump to source from the preview
  • 2,000 usages of any of the shortcut actions
  • 3,500 users who have "enabled hot UI" in settings, which allows them to access the inline editing panel. I don't know how many are actually using the panel.

I didn't realize we could open the quick fix menu from the editor - knowing that makes me less reluctant to remove the outline view.

I'm able to see the outline view for some classes in DevTools, e.g. lib/src/screens/inspector/inspector_tree_controller.dart without having an app running, so I'm not sure what's going wrong in your situation. I think at first when I opened a hello flutter app, it wasn't working though, so I believe it's not consistent.

@kenzieschmoll
Copy link
Member Author

I'm able to see the outline view for some classes in DevTools, e.g. lib/src/screens/inspector/inspector_tree_controller.dart without having an app running, so I'm not sure what's going wrong in your situation. I think at first when I opened a hello flutter app, it wasn't working though, so I believe it's not consistent.

Once I killed the app I was running, I still had access to the Flutter Outline view. So maybe it only works after running an app at least once?

@helin24 helin24 added this to the M80 milestone May 21, 2024
@helin24
Copy link
Member

helin24 commented May 21, 2024

We're going to close this for now since we want the outline buttons for discoverability

@helin24 helin24 closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants