Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[in_app_purchase] Use StoreKit 2 APIs #116383

Open
bahadirarslan opened this issue Dec 1, 2022 · 14 comments
Open

[in_app_purchase] Use StoreKit 2 APIs #116383

bahadirarslan opened this issue Dec 1, 2022 · 14 comments
Assignees
Labels
c: proposal A detailed proposal for a change to Flutter p: in_app_purchase Plugin for in-app purchase P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team

Comments

@bahadirarslan
Copy link

As you are aware Apple updated StoreKit and released StoreKit 2 last year which includes bunches of new features and some changes especially it uses JWT tokens so there is no need to make another call to Apple to verify receipts.

I searched issues, PR's about Store Kit 2 but couldn't see anything so I wanted to ask is there are any plans about using StoreKit 2?

@darshankawar darshankawar added the in triage Presently being triaged by the triage team label Dec 2, 2022
@darshankawar
Copy link
Member

Treating this as a potential proposal and for team's tracking.

@darshankawar darshankawar added p: first party p: in_app_purchase Plugin for in-app purchase platform-ios iOS applications specifically c: proposal A detailed proposal for a change to Flutter and removed in triage Presently being triaged by the triage team labels Dec 2, 2022
@jmagman
Copy link
Member

jmagman commented Dec 2, 2022

We have a design doc for this that, currently blocked on in_app_purchase plugin migrating to Swift.

See also https://flutter.dev/go/ios-plugins-swift-migration and comment in that doc.

@cyanglaz I don't see an open GitHub issue tracking this work, are you aware of one?

@cyanglaz
Copy link
Contributor

cyanglaz commented Dec 2, 2022

@cyanglaz I don't see an open GitHub issue tracking this work, are you aware of one?

No, I think we can use this one.

@cyanglaz cyanglaz added the P3 Issues that are less important to the Flutter project label Dec 2, 2022
@jmagman jmagman changed the title [in_app_purchase] Supporting StoreKit 2? [in_app_purchase] Use StoreKit 2 APIs Dec 2, 2022
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
@Hixie Hixie removed the plugin label Jul 6, 2023
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team labels Jul 8, 2023
@bahadirarslan

This comment was marked as duplicate.

@saviourdog

This comment was marked as duplicate.

2 similar comments
@dodatw

This comment was marked as duplicate.

@caibou

This comment was marked as duplicate.

@LegendAF
Copy link

Where exactly is the starting point to get the ball rolling on supporting StoreKit 2? How can the community help? It has been 2 years and supporting subscriptions with in_app_purchase is more painful than it should be.

@jmagman
Copy link
Member

jmagman commented Jan 24, 2024

We definitely hear you that this is still really painful to use and that it has been for a few years.

There are three pieces to this:

The community can help us by testing these incremental changes and filing issues so we can fix them asap.

@dodatw
Copy link

dodatw commented Jan 25, 2024

@jmagman Thank your update.
Is there any schedule, roadmap for these task?
We are waiting long time. StoreKit2 can help us improve some payment issue. It is good for app developer.

@jmagman
Copy link
Member

jmagman commented Jan 25, 2024

I can't give you a schedule, but you can track our progress in #119106, #117910, and this issue. For example flutter/packages#5910 had updates 15 minutes ago.

We certainly know it is a good thing to do for app developers. 🙂 Further commenters please review Do not add "me too" or "same" or "is there an update" comments to bugs and When will my bug be fixed? in our wiki, let's keep comments focused on meaningful content. Thanks!

@jmagman
Copy link
Member

jmagman commented Mar 18, 2024

To give an update to #116383 (comment), the work to migrate to pigeon is complete.

We were missing test coverage validating we don't cause regressions with this migration, and the unit test backfilling is complete. We're working on adding black box UI tests, though there have been some issues with the .storekit config file.

The Objective-C --> Swift migration has just begun #119106. Once that is complete, the StoreKit2 APIs can be adopted.

We don't have a schedule, but this is being actively worked on.

We certainly know it is a good thing to do for app developers. 🙂 Further commenters please review Do not add "me too" or "same" or "is there an update" comments to bugs and When will my bug be fixed? in our wiki, let's keep comments focused on meaningful content. Thanks!

@mehrzut

This comment was marked as duplicate.

@SpajicM
Copy link

SpajicM commented Apr 27, 2024

Hey, any updates?

It's being worked on:
flutter/packages#6561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: proposal A detailed proposal for a change to Flutter p: in_app_purchase Plugin for in-app purchase P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team
Projects
None yet
Development

No branches or pull requests