-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navigation_and_routing
to handle initial path before login
#947
Comments
I want to work on this problem can i be assigned to this problem |
@johnpryan, since this was your sample originally, I'd love to have your opinion on this. |
Makes sense, the way I would do this is to add a |
It looks like there may be two people interested in implementing this. @asashour, you were the first to suggest the change, so if you're interested in implementing it, I'll leave it to you. |
Thanks all for your feedback. @ramanjitsingh-hub please go ahead, I hope one week is enough to raise a PR. If you want more ideas, we can have an error message when the username/password is empty, or tests to be added for the login or the navigation. As mentioned in CONTRIBUTING, it is better to discuss the changes before spending time implementing them. |
Hi @RedBrogdon Is this issue still there in the app? I am not able to reproduce the scenario mentioned by @asashour . |
The issue is still reprodubile. The initial URL should be something like |
so is there any way to pass a redirect parameter ? |
…ter#947 ) This commit introduces a new functionality in the navigation_and_routing module. Now, if a user tries to access a specific route before logging in, the application will remember this initial route. After the user logs in, they will be redirected back to this initial route instead of a default route.
Would the below scenario add a value to the sample:
/book/3
/signin
Expected
/book/3
Actual
/books/popular
The text was updated successfully, but these errors were encountered: