Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it safe to call this on every startup? #16

Closed
Theunodb opened this issue Feb 13, 2020 · 5 comments
Closed

Is it safe to call this on every startup? #16

Theunodb opened this issue Feb 13, 2020 · 5 comments

Comments

@Theunodb
Copy link

Thank you for the package!

Is it safe to call on every startup? Or do we need to keep track if we requested for review before?

Ex.
If you do the request on every startup / init, will the user see it every single time? Or do you need to keep track in shared preferences / somewhere to ensure that you only send the request once per version?

@Theunodb Theunodb changed the title Is it save to call this on every startup? Is it safe to call this on every startup? Feb 18, 2020
@Theunodb
Copy link
Author

Theunodb commented Mar 23, 2020

FYI, its not safe to call on every startup.

On android it takes the user to the store everytime you open the app. For now you need to keep track yourself if it has been shown or not.

@obrunsmann
Copy link

@Theunodb Having the same question. I currently only call AppReview.requestReview on iOS. So have you checked if this call might be save if used only on iOS?

Because in my current build I see the popup coming up every time even if I have already rated the app but I am not sure if this is just related to my app ownership or to the ad hoc distribution.

@Theunodb
Copy link
Author

@Theunodb Having the same question. I currently only call AppReview.requestReview on iOS. So have you checked if this call might be save if used only on iOS?

Because in my current build I see the popup coming up every time even if I have already rated the app but I am not sure if this is just related to my app ownership or to the ad hoc distribution.

As far as i know On iOS the OS determines when to display the review popup. I can confirm that it doesn’t display every time on iOS for live releases. It does however display on debug for every request.

I ended up keeping track myself just in case

@obrunsmann
Copy link

Okay my update is published in the app store. The situation is as follows:

iOS:
As the AppReview.requestReview is handled by apple the modal dialog is only shown if the user has not yet rated the app. Otherweise the modal is fully hidden. So it is safe to call this method as often as wanted.
In Development and Ad Hoc Builds the Popup shows on every call.

Android:
As @Theunodb already told: While android redirects inside the play store page, it is not safe and a massive UX degradation to call this without expected by the user.

@rodydavis
Copy link
Member

In my applications i only call the ios on startup and use shared preferences to know when to show android.

@rodydavis rodydavis pinned this issue May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants