-
-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(share_plus): add sharePositionOrigin parameter to shareUri #2517
fix(share_plus): add sharePositionOrigin parameter to shareUri #2517
Conversation
It might make sense to add in the |
Thanks for the contribution @rodruiz I will take a look at it.
I think it would be nice to have subject param as well (that may help with issues like #1956), but I'd prefer if it can be done in a different PR. Anyone willing to do it, please go ahead! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, added one comment to improve code formatting.
For what I see, the iOS naive implementation was already in place, so only dart code needed changes.
I will do a quick test before final approval.
Thanks!
Sorry, I forgot to merge this one. Going to merge main, and probably will merge after if everything is still good. |
Description
share_plus requires iPad users to provide the sharePositionOrigin parameter. This parameter is not available in the shareUri method.
When the sharePositionOrigin parameter is not provided on iPads you will see the following error:
This PR also:
Related Issues
Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).