fix(share_plus): Ensure subject is not null before calling putExtra(Intent.EXTRA_SUBJECT, subject) #2518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My friend who would share links via
share_plus
through Verizon's Message+ app, faced an issue where there would always be an additional null message alongside the shared link:After doing a lot of digging and trying different things to try to fix this, I noticed that
Intent.EXTRA_SUBJECT
is always set to null when a subject is not specified. I suspected that this was the issue, given it was only happening for this one messaging platform, which may not filter out a null subject like most others do. Sure enough, after using my fork in place of the officialshare_plus
package and having my friend send me a link again, this issue was fixed. I suspect that there may be other platforms affected by this as well.Related Issues
N/A
Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).