Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(share_plus): Ensure subject is not null before calling putExtra(Intent.EXTRA_SUBJECT, subject) #2518

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

jmsheff
Copy link
Contributor

@jmsheff jmsheff commented Jan 10, 2024

Description

My friend who would share links via share_plus through Verizon's Message+ app, faced an issue where there would always be an additional null message alongside the shared link:

Screenshot 2024-01-10 at 3 14 34 PM

After doing a lot of digging and trying different things to try to fix this, I noticed that Intent.EXTRA_SUBJECT is always set to null when a subject is not specified. I suspected that this was the issue, given it was only happening for this one messaging platform, which may not filter out a null subject like most others do. Sure enough, after using my fork in place of the official share_plus package and having my friend send me a link again, this issue was fixed. I suspect that there may be other platforms affected by this as well.

Related Issues

N/A

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@jmsheff jmsheff changed the title fix: Ensure subject is not null before calling putExtra(Intent.EXTRA_SUBJECT, subject) fix(share_plus): Ensure subject is not null before calling putExtra(Intent.EXTRA_SUBJECT, subject) Jan 10, 2024
Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your investigation and contribution. Looks good to me.

Will release next week.

@vbuberen vbuberen merged commit f0bbbef into fluttercommunity:main Jan 20, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants