refactor(package_info_plus): Migrate Android example to use the new plugins declaration #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbuberen
commented
Mar 17, 2024
| allprojects { | ||
| repositories { | ||
| google() | ||
| mavenCentral() | ||
| } | ||
| } | ||
|
|
||
| rootProject.buildDir = '../build' | ||
| rootProject.layout.buildDirectory = '../build' |
There was a problem hiding this comment.
This is not related to the guidance that I shared, but something that was deprecated in Gradle 8.2.
https://docs.gradle.org/current/userguide/upgrading_version_8.html#project_builddir
Considering that we require 8.4 now due to Android Gradle Plugin 8.3.0, I thought that it won't hurt to address this deprecation as well.
There was a problem hiding this comment.
Reverted this change to stick with only changes from the guidance I shared. Hope it works now.
There was a problem hiding this comment.
Looks like after reverting this change all works as expected.
|
Hmm, it is strange that such error happens as it works fine locally 🤔 |
vbuberen
force-pushed
the
refactor/gradle_plugins_declaration
branch
from
a130a6f
to
3491dad
Compare
vbuberen
force-pushed
the
refactor/gradle_plugins_declaration
branch
from
a4c02e7
to
e7f2f45
Compare
This was referenced Mar 21, 2024
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Considering that fact that some of Plug Plugins will require Flutter 3.19 as min version in their next release I decided to also address the deprecation in how we declare Android related plugins in example apps. Currently users would see warnings during example app builds like this one: https://github.com/fluttercommunity/plus_plugins/actions/runs/8308735389/job/22743183649#step:5:96
There is also an official guidance from the Flutter team on this topic: https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply
With this change our example apps will be more or less up to date and show a good example on how to apply the new approach to apps.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).