Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(share_plus): Resolve deprecation warning in Android part #2717

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

vbuberen
Copy link
Collaborator

Description

Minor change to see less warnings during the build. As we use that broadcast receiver only when use withResult, which works only for Android API 22 and newer, this annotation effects nothing except of dropping lint warning which appears due to Intent.EXTRA_CHOSEN_COMPONENT otherwise.

In the #2519 there is one more deprecation mentioned, but it was valid only for compile SDK 33 as in 34 this warning doesn't appear.

Related Issues

Closes #2519

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen vbuberen added the share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin label Mar 17, 2024
@vbuberen vbuberen merged commit 5913ac7 into main Mar 17, 2024
18 of 19 checks passed
@vbuberen vbuberen deleted the fix/share_plus_android_deprecation_warn branch March 17, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin
Projects
None yet
2 participants