Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(share_plus): Add info regarding localization on Apple to README #2764

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

miquelbeltran
Copy link
Member

Description

Improves the README.md adding an explanation on how to deal with different localizations and the share sheet on iOS.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen
Copy link
Collaborator

I remember some more issues about this, but they are closed now, I suppose
👍🏻

@miquelbeltran miquelbeltran merged commit 43f9a30 into main Mar 30, 2024
4 checks passed
@miquelbeltran miquelbeltran deleted the miquelbeltran/2696 branch March 30, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants