feat(share_plus): share XFile created using File.fromData() #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…romData() if file doesn't contain path then make new file in TemporaryDirectory and return with path
|
melos run format gives this error Unable to run "clang-format". Make sure that it is in your path, or provide a full path with --clang-format. |
dipakp2726
changed the title
|
one of test is failing as sharing empty file no longer throws assertion error |
dipakp2726
changed the title
packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
Outdated
Show resolved
Hide resolved
|
Tentative looking good for me, I need to try this on my PC in the coming days tho. But, in order to approve a merge, you will need to provide a unit test or integration test at least showing this (e.g. call to shareXFile with a file created using fromData) and all failing tests should be fixed (or removed if no longer relevant) |
miquelbeltran
changed the title
packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
Outdated
Show resolved
Hide resolved
packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
Outdated
Show resolved
Hide resolved
miquelbeltran
approved these changes
Oct 24, 2022
miquelbeltran
added
Hacktoberfest
|
Let's wait for the integration tests to finish, and we can merge |
miquelbeltran
changed the title
|
Seems that emulator with API 32 not having a day today, but the other API levels passed and the error is unrelated, so giving it a go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in shareXfile if sharedFile doesn't contain path
then make new file in TemporaryDirectory and return with path
Related Issues
Checklist
CHANGELOG.mdnor thepubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
not sure about this.
!in the title as explained in Conventional Commits).