Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(share_plus): export XFile #1286

Merged
merged 1 commit into from Oct 25, 2022

Conversation

werainkhatri
Copy link
Contributor

Description

  • moved SharePlatform to platform_interface/share_plus_platform.
  • exported cross_file and share_plus_platform in share_plus_platform_interface.dart file (inspiration).
  • exported (by export ... show ...;) XFile in share_plus package (inspiration).
  • hid XFile from file_selector and image_picker in example/lib/main.dart so that this export is tested.

wild ideas, not to be taken too seriously:

  1. should the folders in share_plus_platform_interface/lib be moved to src (same as image_picker)?
  2. Should SharePlatform be renamed to SharePlusPlatform?

Related Issues

Fixes #1271

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miquelbeltran miquelbeltran changed the title feat(share_plus): export XFile fix(share_plus): export XFile Oct 25, 2022
@miquelbeltran miquelbeltran merged commit 1f1786c into fluttercommunity:main Oct 25, 2022
@werainkhatri werainkhatri deleted the export-xfile branch October 25, 2022 05:36
@SirusCodes
Copy link
Contributor

@miquelbeltran when this will be published?

@miquelbeltran
Copy link
Member

We don't have yet a fixed release schedule, but probably during the coming days

@SirusCodes
Copy link
Contributor

Ok can you give an ETA as it is blocking #1070 since published version is not exporting XFile

Should I make a draft PR by depending using path?

@miquelbeltran
Copy link
Member

miquelbeltran commented Oct 26, 2022

You can do a draft PR sure, but I am not sure why you need this released to implement another change. Development should always reference the local libraries and not the ones on pub.dev if you do a proper development setup using melos. So you don't even need to add the dependency by path because your pubspec lock already references it.

@SirusCodes
Copy link
Contributor

if you do a proper development setup using melos. So you don't even need to add the dependency by path because your pubspec lock already references it.

I have never used melos. Will try to configure it. Thanks👍

@miquelbeltran
Copy link
Member

I have never used melos. Will try to configure it. Thanks+1

It is on the Contributors guide, you need it to bootstrap the repo.

Please read the contributors guide carefully and follow it.

@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question]: the class XFILE doesn't exist.
3 participants